mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-27 08:39:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Ugly patch to make ALTER SEQUENCE OWNED BY not affect the currval() state

Browse Source 
of the sequence.  Since OWNED BY never existed before 8.2, this seems
unlikely to create any compatibility issues.  Other forms of ALTER SEQUENCE
continue to do what they did before, namely update currval to match the
sequence's actual last_val.  That seems wrong on consideration, but we'll
not change it in a minor release --- 8.3 will make that fix.
This commit is contained in:
Tom Lane 2007-10-25 19:15:01 +00:00
parent 72fb03b8c8
commit 9f3309858f
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/backend/commands/sequence.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/sequence.c,v 1.141 2006/10/06 17:13:58 petere Exp $ * $PostgreSQL: pgsql/src/backend/commands/sequence.c,v 1.141.2.1 2007/10/25 19:15:01 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -315,6 +315,7 @@ AlterSequence(AlterSeqStmt *stmt)
Form_pg_sequence seq; Form_pg_sequence seq;
FormData_pg_sequence new; FormData_pg_sequence new;
List *owned_by; List *owned_by;
int64 save_increment;
/* open and AccessShareLock sequence */ /* open and AccessShareLock sequence */
relid = RangeVarGetRelid(stmt->sequence, false); relid = RangeVarGetRelid(stmt->sequence, false);
@ -325,6 +326,9 @@ AlterSequence(AlterSeqStmt *stmt)
aclcheck_error(ACLCHECK_NOT_OWNER, ACL_KIND_CLASS, aclcheck_error(ACLCHECK_NOT_OWNER, ACL_KIND_CLASS,
stmt->sequence->relname); stmt->sequence->relname);
/* hack to keep ALTER SEQUENCE OWNED BY from changing currval state */
save_increment = elm->increment;
/* lock page' buffer and read tuple into new sequence structure */ /* lock page' buffer and read tuple into new sequence structure */
seq = read_info(elm, seqrel, &buf); seq = read_info(elm, seqrel, &buf);
page = BufferGetPage(buf); page = BufferGetPage(buf);
@ -338,10 +342,18 @@ AlterSequence(AlterSeqStmt *stmt)
/* Now okay to update the on-disk tuple */ /* Now okay to update the on-disk tuple */
memcpy(seq, &new, sizeof(FormData_pg_sequence)); memcpy(seq, &new, sizeof(FormData_pg_sequence));
/* Clear local cache so that we don't think we have cached numbers */ if (owned_by)
elm->last = new.last_value; /* last returned number */ {
elm->cached = new.last_value; /* last cached number (forget cached /* Restore previous state of elm (assume nothing else changes) */
elm->increment = save_increment;
}
else
{
/* Clear local cache so that we don't think we have cached numbers */
elm->last = new.last_value; /* last returned number */
elm->cached = new.last_value; /* last cached number (forget cached
* values) */ * values) */
}
START_CRIT_SECTION(); START_CRIT_SECTION();