mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2025-01-18 18:44:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary PQconsumeInput call from PQputCopyData; it's redundant

Browse Source 
because pqSendSome will absorb input data anytime it'd be forced to block.
Avoiding a kernel call per PQputCopyData call helps COPY speed materially.

Alon Goldshuv
This commit is contained in:
Tom Lane 2006-01-25 20:44:32 +00:00
parent 3a0a16cb7e
commit 9b012311f8
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/interfaces/libpq/fe-exec.c
View File

@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/interfaces/libpq/fe-exec.c,v 1.178 2006/01/11 08:43:13 neilc Exp $
* $PostgreSQL: pgsql/src/interfaces/libpq/fe-exec.c,v 1.179 2006/01/25 20:44:32 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -1476,13 +1476,13 @@ PQputCopyData(PGconn *conn, const char *buffer, int nbytes)
}
/*
* Check for NOTICE messages coming back from the server. Since the
* server might generate multiple notices during the COPY, we have to
* consume those in a reasonably prompt fashion to prevent the comm
* buffers from filling up and possibly blocking the server.
* Process any NOTICE or NOTIFY messages that might be pending in the
* input buffer. Since the server might generate many notices during
* the COPY, we want to clean those out reasonably promptly to prevent
* indefinite expansion of the input buffer. (Note: the actual read
* of input data into the input buffer happens down inside pqSendSome,
* but it's not authorized to get rid of the data again.)
*/
if (!PQconsumeInput(conn))
return -1; /* I/O failure */
parseInput(conn);
if (nbytes > 0)