mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-27 08:39:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid consuming an XID during vac_truncate_clog().

Browse Source 
vac_truncate_clog() uses its own transaction ID as the comparison point in
a sanity check that no database's datfrozenxid has already wrapped around
"into the future".  That was probably fine when written, but in a lazy
vacuum we won't have assigned an XID, so calling GetCurrentTransactionId()
causes an XID to be assigned when otherwise one would not be.  Most of the
time that's not a big problem ... but if we are hard up against the
wraparound limit, consuming XIDs during antiwraparound vacuums is a very
bad thing.

Instead, use ReadNewTransactionId(), which not only avoids this problem
but is in itself a better comparison point to test whether wraparound
has already occurred.

Report and patch by Alexander Korotkov.  Back-patch to all versions.

Report: <CAPpHfdspOkmiQsxh-UZw2chM6dRMwXAJGEmmbmqYR=yvM7-s6A@mail.gmail.com>
This commit is contained in:
Tom Lane 2016-05-24 15:20:12 -04:00
parent 0c7cd45b6d
commit 996d273978
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/commands/vacuum.c
View File

@ -1051,7 +1051,7 @@ vac_truncate_clog(TransactionId frozenXID,
TransactionId lastSaneFrozenXid,
MultiXactId lastSaneMinMulti)
{
TransactionId myXID = GetCurrentTransactionId();
TransactionId nextXID = ReadNewTransactionId();
Relation relation;
HeapScanDesc scan;
HeapTuple tuple;
@ -1100,7 +1100,7 @@ vac_truncate_clog(TransactionId frozenXID,
MultiXactIdPrecedes(lastSaneMinMulti, dbform->datminmxid))
bogus = true;
if (TransactionIdPrecedes(myXID, dbform->datfrozenxid))
if (TransactionIdPrecedes(nextXID, dbform->datfrozenxid))
frozenAlreadyWrapped = true;
else if (TransactionIdPrecedes(dbform->datfrozenxid, frozenXID))
{