mirror of
https://git.postgresql.org/git/postgresql.git
synced 2025-01-06 15:24:56 +08:00
Add subquery pullup handling for WindowClause runCondition
9d9c02ccd
added code to allow WindowAgg to take some shortcuts when a monotonic WindowFunc reached some value that it could never come back from due to the function's monotonic nature. That commit added a runCondition field to WindowClause to store the condition which, when it becomes false we can start taking shortcuts in nodeWindowAgg.c. Here we fix an issue where subquery pullups didn't properly update the runCondition to update the Vars to properly reference the new query level. Here we also add a missing call to preprocess_expression() for the WindowClause's runCondtion. The WindowFuncs in the targetlist will have had this process done, so we must also do it for the WindowFuncs in the runCondition so that they can be correctly found in the targetlist during setrefs.c Bug: #17709 Reported-by: Alexey Makhmutov Author: Richard Guo, David Rowley Discussion: https://postgr.es/m/17709-4f557160e3e8ee9a@postgresql.org Backpatch-through: 15, where9d9c02ccd
was introduced
This commit is contained in:
parent
66dcb09246
commit
94985c2102
@ -833,6 +833,9 @@ subquery_planner(PlannerGlobal *glob, Query *parse,
|
||||
EXPRKIND_LIMIT);
|
||||
wc->endOffset = preprocess_expression(root, wc->endOffset,
|
||||
EXPRKIND_LIMIT);
|
||||
wc->runCondition = (List *) preprocess_expression(root,
|
||||
(Node *) wc->runCondition,
|
||||
EXPRKIND_TARGET);
|
||||
}
|
||||
|
||||
parse->limitOffset = preprocess_expression(root, parse->limitOffset,
|
||||
|
@ -2120,6 +2120,15 @@ perform_pullup_replace_vars(PlannerInfo *root,
|
||||
pullup_replace_vars((Node *) parse->targetList, rvcontext);
|
||||
parse->returningList = (List *)
|
||||
pullup_replace_vars((Node *) parse->returningList, rvcontext);
|
||||
|
||||
foreach(lc, parse->windowClause)
|
||||
{
|
||||
WindowClause *wc = lfirst_node(WindowClause, lc);
|
||||
|
||||
if (wc->runCondition != NIL)
|
||||
wc->runCondition = (List *)
|
||||
pullup_replace_vars((Node *) wc->runCondition, rvcontext);
|
||||
}
|
||||
if (parse->onConflict)
|
||||
{
|
||||
parse->onConflict->onConflictSet = (List *)
|
||||
|
Loading…
Reference in New Issue
Block a user