mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2025-01-12 18:34:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Put a critical section around update of hash index metapage. Per

Browse Source 
discussion with Qingqing Zhou.
This commit is contained in:
Tom Lane 2005-06-09 18:23:50 +00:00
parent 65d27324c3
commit 82358ca936
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/backend/access/hash/hashpage.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/access/hash/hashpage.c,v 1.49 2005/05/11 01:26:01 neilc Exp $ * $PostgreSQL: pgsql/src/backend/access/hash/hashpage.c,v 1.50 2005/06/09 18:23:50 tgl Exp $
* *
* NOTES * NOTES
* Postgres hash pages look like ordinary relation pages. The opaque * Postgres hash pages look like ordinary relation pages. The opaque
@ -421,7 +421,15 @@ _hash_expandtable(Relation rel, Buffer metabuf)
/* /*
* Okay to proceed with split. Update the metapage bucket mapping * Okay to proceed with split. Update the metapage bucket mapping
* info. * info.
*
* Since we are scribbling on the metapage data right in the shared
* buffer, any failure in this next little bit leaves us with a big
* problem: the metapage is effectively corrupt but could get written
* back to disk. We don't really expect any failure, but just to be
* sure, establish a critical section.
*/ */
START_CRIT_SECTION();
metap->hashm_maxbucket = new_bucket; metap->hashm_maxbucket = new_bucket;
if (new_bucket > metap->hashm_highmask) if (new_bucket > metap->hashm_highmask)
@ -456,6 +464,9 @@ _hash_expandtable(Relation rel, Buffer metabuf)
if (!_hash_try_getlock(rel, start_nblkno, HASH_EXCLUSIVE)) if (!_hash_try_getlock(rel, start_nblkno, HASH_EXCLUSIVE))
elog(PANIC, "could not get lock on supposedly new bucket"); elog(PANIC, "could not get lock on supposedly new bucket");
/* Done mucking with metapage */
END_CRIT_SECTION();
/* /*
* Copy bucket mapping info now; this saves re-accessing the meta page * Copy bucket mapping info now; this saves re-accessing the meta page
* inside _hash_splitbucket's inner loop. Note that once we drop the * inside _hash_splitbucket's inner loop. Note that once we drop the