mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2025-01-12 18:34:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add comments about why we set LC_CTYPE in WIN32 for time when we don't

Browse Source 
actually access it, per information from Hiroshi.
This commit is contained in:
Bruce Momjian 2010-04-26 14:17:52 +00:00
parent ab93cd9b05
commit 7eb6e6b48a
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/utils/adt/pg_locale.c
View File

@ -4,7 +4,7 @@
* *
* Portions Copyright (c) 2002-2010, PostgreSQL Global Development Group * Portions Copyright (c) 2002-2010, PostgreSQL Global Development Group
* *
* $PostgreSQL: pgsql/src/backend/utils/adt/pg_locale.c,v 1.55 2010/04/24 22:54:56 momjian Exp $ * $PostgreSQL: pgsql/src/backend/utils/adt/pg_locale.c,v 1.56 2010/04/26 14:17:52 momjian Exp $
* *
*----------------------------------------------------------------------- *-----------------------------------------------------------------------
*/ */
@ -627,7 +627,15 @@ cache_locale_time(void)
save_lc_time = pstrdup(save_lc_time); save_lc_time = pstrdup(save_lc_time);
#ifdef WIN32 #ifdef WIN32
/* See the WIN32 comment near the top of PGLC_localeconv() */ /*
* On WIN32, there is no way to get locale-specific time values in a
* specified locale, like we do for monetary/numeric. We can only get
* CP_ACP (see strftime_win32) or UTF16. Therefore, we get UTF16 and
* convert it to the database locale. However, wcsftime() internally
* uses LC_CTYPE, so we set it here. See the WIN32 comment near the
* top of PGLC_localeconv().
*/
/* save user's value of ctype locale */ /* save user's value of ctype locale */
save_lc_ctype = setlocale(LC_CTYPE, NULL); save_lc_ctype = setlocale(LC_CTYPE, NULL);
if (save_lc_ctype) if (save_lc_ctype)