mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-11-27 07:21:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix copy-pasto in freeing memory on error in vacuumlo.

Browse Source 
It's harmless to call PQfreemem() with a NULL argument, so the only
consequence was that if allocating 'schema' failed, but allocating 'table'
or 'field' succeeded, we would leak a bit of memory. That's highly
unlikely to happen, so this is just academical, but let's get it right.

Per bug #15838 from Timur Birsh. Backpatch back to 9.5, where the
PQfreemem() calls were introduced.

Discussion: https://www.postgresql.org/message-id/15838-3221652c72c5e69d@postgresql.org
This commit is contained in:
Heikki Linnakangas 2019-06-07 12:42:27 +03:00
parent a36c84c3e4
commit 77b68e3a4f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/vacuumlo/vacuumlo.c
View File

@ -243,9 +243,9 @@ vacuumlo(const char *database, const struct _param *param)
PQfinish(conn); PQfinish(conn);
if (schema != NULL) if (schema != NULL)
PQfreemem(schema); PQfreemem(schema);
if (schema != NULL) if (table != NULL)
PQfreemem(table); PQfreemem(table);
if (schema != NULL) if (field != NULL)
PQfreemem(field); PQfreemem(field);
return -1; return -1;
} }