mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-21 08:29:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use InvalidSnapshot, now SnapshotNow, as the default snapshot.

Browse Source 
As far as I can determine, there's no code in the core distribution
that fails to explicitly set the snapshot of a scan or executor
state.  If there is any such code, this will probably cause it to
seg fault; friendlier suggestions were discussed on pgsql-hackers,
but there was no consensus that anything more than this was
needed.

This is another step towards the hoped-for complete removal of
SnapshotNow.
This commit is contained in:
Robert Haas 2013-07-23 10:58:32 -04:00
parent e6055061c5
commit 765ad89be3
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/access/index/genam.c
View File

@ -79,7 +79,7 @@ RelationGetIndexScan(Relation indexRelation, int nkeys, int norderbys)
scan->heapRelation = NULL; /* may be set later */ scan->heapRelation = NULL; /* may be set later */
scan->indexRelation = indexRelation; scan->indexRelation = indexRelation;
scan->xs_snapshot = SnapshotNow; /* may be set later */ scan->xs_snapshot = InvalidSnapshot; /* caller must initialize this */
scan->numberOfKeys = nkeys; scan->numberOfKeys = nkeys;
scan->numberOfOrderBys = norderbys; scan->numberOfOrderBys = norderbys;

2
src/backend/executor/execUtils.c
View File

@ -105,7 +105,7 @@ CreateExecutorState(void)
* Initialize all fields of the Executor State structure * Initialize all fields of the Executor State structure
*/ */
estate->es_direction = ForwardScanDirection; estate->es_direction = ForwardScanDirection;
estate->es_snapshot = SnapshotNow; estate->es_snapshot = InvalidSnapshot; /* caller must initialize this */
estate->es_crosscheck_snapshot = InvalidSnapshot; /* no crosscheck */ estate->es_crosscheck_snapshot = InvalidSnapshot; /* no crosscheck */
estate->es_range_table = NIL; estate->es_range_table = NIL;
estate->es_plannedstmt = NULL; estate->es_plannedstmt = NULL;