mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2025-01-30 19:00:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Unbreak unlogged tables.

Browse Source 
I broke this in commit 5da79169d3, which
was obviously insufficiently well tested.  Add some regression tests
in the hope of making future slip-ups more likely to be noticed.
This commit is contained in:
Robert Haas 2011-07-22 16:15:43 -04:00
parent 43aa40e155
commit 6f1be5a67a
3 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/catalog/namespace.c
View File

@ -506,9 +506,10 @@ RangeVarAdjustRelationPersistence(RangeVar *newRelation, Oid nspid)
errmsg("cannot create relations in temporary schemas of other sessions"))); errmsg("cannot create relations in temporary schemas of other sessions")));
break; break;
default: default:
ereport(ERROR, if (isAnyTempNamespace(nspid))
(errcode(ERRCODE_INVALID_TABLE_DEFINITION), ereport(ERROR,
errmsg("only temporary relations may be created in temporary schemas"))); (errcode(ERRCODE_INVALID_TABLE_DEFINITION),
errmsg("only temporary relations may be created in temporary schemas")));
} }
} }

11
src/test/regress/expected/create_table.out
View File

@ -204,3 +204,14 @@ CREATE TABLE IF NOT EXISTS test_tsvector(
t text t text
); );
NOTICE: relation "test_tsvector" already exists, skipping NOTICE: relation "test_tsvector" already exists, skipping
CREATE UNLOGGED TABLE unlogged1 (a int); -- OK
INSERT INTO unlogged1 VALUES (42);
CREATE UNLOGGED TABLE public.unlogged2 (a int); -- also OK
CREATE UNLOGGED TABLE pg_temp.unlogged3 (a int); -- not OK
ERROR: only temporary relations may be created in temporary schemas
CREATE TABLE pg_temp.implicity_temp (a int); -- OK
CREATE TEMP TABLE explicitly_temp (a int); -- also OK
CREATE TEMP TABLE pg_temp.doubly_temp (a int); -- also OK
CREATE TEMP TABLE public.temp_to_perm (a int); -- not OK
ERROR: cannot create temporary relation in non-temporary schema
DROP TABLE unlogged1, public.unlogged2;

10
src/test/regress/sql/create_table.sql
View File

@ -240,3 +240,13 @@ CREATE TABLE IF NOT EXISTS test_tsvector(
CREATE TABLE IF NOT EXISTS test_tsvector( CREATE TABLE IF NOT EXISTS test_tsvector(
t text t text
); );
CREATE UNLOGGED TABLE unlogged1 (a int); -- OK
INSERT INTO unlogged1 VALUES (42);
CREATE UNLOGGED TABLE public.unlogged2 (a int); -- also OK
CREATE UNLOGGED TABLE pg_temp.unlogged3 (a int); -- not OK
CREATE TABLE pg_temp.implicity_temp (a int); -- OK
CREATE TEMP TABLE explicitly_temp (a int); -- also OK
CREATE TEMP TABLE pg_temp.doubly_temp (a int); -- also OK
CREATE TEMP TABLE public.temp_to_perm (a int); -- not OK
DROP TABLE unlogged1, public.unlogged2;