mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-12-27 08:39:28 +08:00
Fix portability problem induced by commit a6f6b7819
.
pg_xlogdump includes bufmgr.h. With a compiler that emits code for static inline functions even when they're unreferenced, that leads to unresolved external references in the new static-inline version of BufferGetPage(). So hide it with #ifndef FRONTEND, as we've done for similar issues elsewhere. Per buildfarm member pademelon.
This commit is contained in:
parent
ba8fe38f58
commit
6b85d4ba9b
@ -4299,7 +4299,7 @@ IssuePendingWritebacks(WritebackContext *context)
|
||||
* For best performance, keep the tests that are fastest and/or most likely to
|
||||
* exclude a page from old snapshot testing near the front.
|
||||
*/
|
||||
extern void
|
||||
void
|
||||
TestForOldSnapshot(Snapshot snapshot, Relation relation, Page page)
|
||||
{
|
||||
Assert(relation != NULL);
|
||||
|
@ -252,6 +252,15 @@ extern void FreeAccessStrategy(BufferAccessStrategy strategy);
|
||||
|
||||
/* inline functions */
|
||||
|
||||
/*
|
||||
* Although this header file is nominally backend-only, certain frontend
|
||||
* programs like pg_xlogdump include it. For compilers that emit static
|
||||
* inline functions even when they're unused, that leads to unsatisfied
|
||||
* external references; hence hide these with #ifndef FRONTEND.
|
||||
*/
|
||||
|
||||
#ifndef FRONTEND
|
||||
|
||||
/*
|
||||
* BufferGetPage
|
||||
* Returns the page associated with a buffer.
|
||||
@ -272,4 +281,6 @@ BufferGetPage(Buffer buffer, Snapshot snapshot, Relation relation,
|
||||
return page;
|
||||
}
|
||||
|
||||
#endif
|
||||
#endif /* FRONTEND */
|
||||
|
||||
#endif /* BUFMGR_H */
|
||||
|
Loading…
Reference in New Issue
Block a user