From 6b61b641163a0cfea00360a357c1ff0aabfc1535 Mon Sep 17 00:00:00 2001 From: Noah Misch Date: Sun, 1 Mar 2015 13:05:23 -0500 Subject: [PATCH] Unlink static libraries before rebuilding them. When the library already exists in the build directory, "ar" preserves members not named on its command line. This mattered when, for example, a "configure" rerun dropped a file from $(LIBOBJS). libpgport carried the obsolete member until "make clean". Back-patch to 9.0 (all supported versions). --- src/Makefile.shlib | 3 +++ src/port/Makefile | 2 ++ 2 files changed, 5 insertions(+) diff --git a/src/Makefile.shlib b/src/Makefile.shlib index b1ab580722..8616eb6f8f 100644 --- a/src/Makefile.shlib +++ b/src/Makefile.shlib @@ -342,6 +342,7 @@ all-shared-lib: $(shlib) ifndef haslibarule $(stlib): $(OBJS) + rm -f $@ $(LINK.static) $@ $^ $(RANLIB) $@ endif #haslibarule @@ -384,6 +385,7 @@ else # PORTNAME == aix # AIX case $(shlib) $(stlib): $(OBJS) + rm -f $(stlib) $(LINK.static) $(stlib) $^ $(RANLIB) $(stlib) $(MKLDEXPORT) $(stlib) >$(exports_file) @@ -404,6 +406,7 @@ $(shlib): $(OBJS) | $(SHLIB_PREREQS) $(CC) $(CFLAGS) -shared -o $@ $(OBJS) $(LDFLAGS) $(LDFLAGS_SL) $(SHLIB_LINK) $(LIBS) $(LDAP_LIBS_BE) $(stlib): $(OBJS) | $(SHLIB_PREREQS) + rm -f $@ $(LINK.static) $@ $^ $(RANLIB) $@ diff --git a/src/port/Makefile b/src/port/Makefile index c9b153d7da..8589108f55 100644 --- a/src/port/Makefile +++ b/src/port/Makefile @@ -52,6 +52,7 @@ uninstall: rm -f '$(DESTDIR)$(libdir)/libpgport.a' libpgport.a: $(OBJS) + rm -f $@ $(AR) $(AROPT) $@ $^ # thread.o needs PTHREAD_CFLAGS (but thread_srv.o does not) @@ -63,6 +64,7 @@ thread.o: thread.c # libpgport_srv.a: $(OBJS_SRV) + rm -f $@ $(AR) $(AROPT) $@ $^ %_srv.o: %.c