From 5ca40c5d31bc8777f17a43f5b37655e4d47898b9 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 21 Jun 2004 14:12:38 +0000 Subject: [PATCH] Add comment about rationale for continuing to use C library functions instead of src/timezone for timestamping log entries. --- src/backend/utils/error/elog.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index dc881a0067..e47740eded 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -37,7 +37,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.140 2004/06/03 02:08:04 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.141 2004/06/21 14:12:38 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -1214,6 +1214,16 @@ log_line_prefix(StringInfo buf) break; case 't': { + /* + * Note: for %t and %s we deliberately use the C library's + * strftime/localtime, and not the equivalent functions + * from src/timezone. This ensures that all backends + * will report log entries in the same timezone, namely + * whatever C-library setting they inherit from the + * postmaster. If we used src/timezone then local + * settings of the TimeZone GUC variable would confuse + * the log. + */ time_t stamp_time = time(NULL); char strfbuf[128];