mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-27 08:39:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove dead code in pg_dump.

Browse Source 
Coverity quite reasonably complained that this check for fout==NULL
occurred after we'd already dereferenced fout.  However, the check
is just dead code since there is no code path by which CreateArchive
can return a null pointer.  Errors such as can't-open-that-file are
reported down inside CreateArchive, and control doesn't return.
So let's silence the warning by removing the dead code, rather than
continuing to pretend it does something.

Coverity didn't complain about this before 5b5fea2a1, so back-patch
to 9.5 like that patch.
This commit is contained in:
Tom Lane 2016-01-17 11:38:40 -05:00
parent 4189e3d659
commit 57ce9acc04
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/bin/pg_dump/pg_dump.c
View File

@ -617,9 +617,6 @@ main(int argc, char **argv)
/* Register the cleanup hook */ /* Register the cleanup hook */
on_exit_close_archive(fout); on_exit_close_archive(fout);
if (fout == NULL)
exit_horribly(NULL, "could not open output file \"%s\" for writing\n", filename);
/* Let the archiver know how noisy to be */ /* Let the archiver know how noisy to be */
fout->verbose = g_verbose; fout->verbose = g_verbose;