From 548d7260309008b146bd9eaa66f3c5be0a8d725a Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Mon, 12 Jun 2023 16:25:37 +0300 Subject: [PATCH] Remove a few unused global variables and declarations. - Commit 3eb77eba5a, which moved the pending ops queue from md.c to sync.c, introduced a duplicate, unused 'pendingOpsCxt' variable. (I'm surprised none of the compilers or static analysis tools have complained about that.) - Commit c2fe139c20 moved the 'synchronize_seqscans' variable and introduced an extern declaration in tableam.h, making the one in guc_tables.c unnecessary. - Commit 6f0cf87872 removed the 'pgstat_temp_directory' GUC, but forgot to remove the corresponding global variable. - Commit 1b4e729eaa removed the 'pg_krb_realm' GUC, and its global variable, but forgot the declaration in auth.h. Spotted all these by reading the code. --- src/backend/storage/sync/sync.c | 2 -- src/backend/utils/misc/guc_tables.c | 3 --- src/include/libpq/auth.h | 1 - 3 files changed, 6 deletions(-) diff --git a/src/backend/storage/sync/sync.c b/src/backend/storage/sync/sync.c index 768d1dbfc41..04fcb06056d 100644 --- a/src/backend/storage/sync/sync.c +++ b/src/backend/storage/sync/sync.c @@ -37,8 +37,6 @@ #include "utils/inval.h" #include "utils/memutils.h" -static MemoryContext pendingOpsCxt; /* context for the pending ops state */ - /* * In some contexts (currently, standalone backends and the checkpointer) * we keep track of pending fsync operations: we need to remember all relation diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c index 4665b0a35c3..71e27f8eb05 100644 --- a/src/backend/utils/misc/guc_tables.c +++ b/src/backend/utils/misc/guc_tables.c @@ -97,7 +97,6 @@ extern char *default_tablespace; extern char *temp_tablespaces; extern bool ignore_checksum_failure; extern bool ignore_invalid_pages; -extern bool synchronize_seqscans; #ifdef TRACE_SYNCSCAN extern bool trace_syncscan; @@ -530,8 +529,6 @@ char *HbaFileName; char *IdentFileName; char *external_pid_file; -char *pgstat_temp_directory; - char *application_name; int tcp_keepalives_idle; diff --git a/src/include/libpq/auth.h b/src/include/libpq/auth.h index 3b3b2cc4aaa..7fac05b813f 100644 --- a/src/include/libpq/auth.h +++ b/src/include/libpq/auth.h @@ -19,7 +19,6 @@ extern PGDLLIMPORT char *pg_krb_server_keyfile; extern PGDLLIMPORT bool pg_krb_caseins_users; extern PGDLLIMPORT bool pg_gss_accept_delegation; -extern PGDLLIMPORT char *pg_krb_realm; extern void ClientAuthentication(Port *port); extern void sendAuthRequest(Port *port, AuthRequest areq, const char *extradata,