mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-15 08:20:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

pg_basebackup: Cleaner handling when compression is multiply specified.

Browse Source 
Tushar Ahuja discovered that if you use both --compress and --gzip,
or --compress multiple times, the last instance of one of these
options doesn't in all cases overwrite the compression level set by
an earlier option. That's not a serious bug, but it also has nothing
to recommend it. Repair.

Discussion: http://postgr.es/m/CA+TgmoZfP=rsZB_9vDGfhuNgSu_M_09UWu8SjvsP65y_1pQFCg@mail.gmail.com
This commit is contained in:
Robert Haas 2022-01-28 11:40:53 -05:00
parent da505eafca
commit 51891d5a95
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/bin/pg_basebackup/pg_basebackup.c
View File

@ -966,6 +966,12 @@ parse_compress_options(char *src, WalCompressionMethod *methodres,
int firstlen;
char *firstpart;
/*
* clear 'levelres' so that if there are multiple compression options,
* the last one fully overrides the earlier ones
*/
*levelres = 0;
/* check if the option is split in two */
sep = strchr(src, ':');