mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-21 08:29:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid sharing subpath list structure when flattening nested AppendRels.

Browse Source 
In some situations the original coding led to corrupting the child AppendRel's
subpaths list, effectively adding other members of the parent's list to it.
This was usually masked because we never made any further use of the child's
list, but given the right combination of circumstances, we could do so.  The
visible symptom would be a relation getting scanned twice, as in bug #5673
from David Schmitt.

Backpatch to 8.2, which is as far back as the risky coding appears.  The
example submitted by David only fails in 8.4 and later, but I'm not convinced
that there aren't any even-more-obscure cases where 8.2 and 8.3 would fail.
This commit is contained in:
Tom Lane 2010-09-23 19:34:56 -04:00
parent 3f9c2d4a0d
commit 4e60212ab5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/optimizer/path/allpaths.c
View File

@ -350,7 +350,7 @@ set_append_rel_pathlist(PlannerInfo *root, RelOptInfo *rel,
childpath = childrel->cheapest_total_path; childpath = childrel->cheapest_total_path;
if (IsA(childpath, AppendPath)) if (IsA(childpath, AppendPath))
subpaths = list_concat(subpaths, subpaths = list_concat(subpaths,
((AppendPath *) childpath)->subpaths); list_copy(((AppendPath *) childpath)->subpaths));
else else
subpaths = lappend(subpaths, childpath); subpaths = lappend(subpaths, childpath);