mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2025-02-17 19:30:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Drop the temporary tuple slots allocated by pgoutput.

Browse Source 
In pgoutput, when converting the child table's tuple format to match the
parent table's, we temporarily create a new slot to store the converted
tuple. However, we missed to drop such temporary slots, leading to
resource leakage.

Reported-by: Bowen Shi
Author: Hou Zhijie
Reviewed-by: Amit Kapila
Backpatch-through: 15
Discussion: https://postgr.es/m/CAM_vCudv8dc3sjWiPkXx5F2b27UV7_YRKRbtSCcE-pv=cVACGA@mail.gmail.com
This commit is contained in:
Amit Kapila 2024-06-27 11:35:00 +05:30
parent 7467939ea2
commit 3e53492aa7
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/replication/pgoutput/pgoutput.c
View File

@ -1554,6 +1554,16 @@ cleanup:
ancestor = NULL;
}
/* Drop the new slots that were used to store the converted tuples. */
if (relentry->attrmap)
{
if (old_slot)
ExecDropSingleTupleTableSlot(old_slot);
if (new_slot)
ExecDropSingleTupleTableSlot(new_slot);
}
MemoryContextSwitchTo(old);
MemoryContextReset(data->context);
}