mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2025-03-07 19:47:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove ill-conceived Assertion in ProcessClientWriteInterrupt().

Browse Source 
It's perfectly fine to have blocked interrupts when
ProcessClientWriteInterrupt() is called. In fact it's commonly the
case when emitting error reports. And we deal with that correctly.

Even if that'd not be the case, it'd be a bad location for such a
assertion. Because ProcessClientWriteInterrupt() is only called when
the socket is blocked it's hard to hit.

Per Heikki and buildfarm animals nightjar and dunlin.
This commit is contained in:
Andres Freund 2015-02-03 23:52:15 +01:00
parent 2505ce0be0
commit 3a54f4a494
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/tcop/postgres.c
View File

@ -571,8 +571,6 @@ ProcessClientWriteInterrupt(bool blocked)
{
int save_errno = errno;
Assert(InterruptHoldoffCount == 0 && CritSectionCount == 0);
/*
* We only want to process the interrupt here if socket writes are
* blocking to increase the chance to get an error message to the