From 39b0c7681e465f3e486ca2a5d13fbbafbe25cb1a Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 26 Apr 2014 12:22:09 -0400 Subject: [PATCH] Record the proper typmod for an index expression column. We should use exprTypmod() to extract the typmod of the expression, instead of just blindly storing -1. This seems to have been an aboriginal oversight in commit fc8d970cbcdd6f025475822a4cf01dfda0873226 which introduced general-expression indexes. The consequences are only cosmetic at present, since the index machinery doesn't really look at typmod for index columns; but still it seems best to describe the column type as precisely as we can. Per off-list complaint from Thomas Fanghaenel. --- src/backend/catalog/index.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c index 47f0647cb41..c932c833421 100644 --- a/src/backend/catalog/index.c +++ b/src/backend/catalog/index.c @@ -389,7 +389,7 @@ ConstructTupleDescriptor(Relation heapRelation, to->attalign = typeTup->typalign; to->attstattarget = -1; to->attcacheoff = -1; - to->atttypmod = -1; + to->atttypmod = exprTypmod(indexkey); to->attislocal = true; to->attcollation = collationObjectId[i];