mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-27 08:39:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

SPI_cursor_open failed to enforce that only read-only queries could be

Browse Source 
executed in read_only mode.  This could lead to various relatively-subtle
failures, such as an allegedly stable function returning non-stable results.
Bug goes all the way back to the introduction of read-only mode in 8.0.
Per report from Gaetano Mendola.
This commit is contained in:
Tom Lane 2007-03-17 03:15:47 +00:00
parent 009dac8ed4
commit 32311dfaa0
1 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/backend/executor/spi.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/executor/spi.c,v 1.165.2.2 2006/12/26 16:56:22 tgl Exp $ * $PostgreSQL: pgsql/src/backend/executor/spi.c,v 1.165.2.3 2007/03/17 03:15:47 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -870,6 +870,26 @@ SPI_cursor_open(const char *name, void *plan,
if (list_length(qtlist) != list_length(ptlist)) if (list_length(qtlist) != list_length(ptlist))
elog(ERROR, "corrupted SPI plan lists"); elog(ERROR, "corrupted SPI plan lists");
/*
* If told to be read-only, we'd better check for read-only queries.
*/
if (read_only)
{
ListCell *lc;
foreach(lc, qtlist)
{
Query *qry = (Query *) lfirst(lc);
if (!QueryIsReadOnly(qry))
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
/* translator: %s is a SQL statement name */
errmsg("%s is not allowed in a non-volatile function",
CreateQueryTag(qry))));
}
}
/* Reset SPI result (note we deliberately don't touch lastoid) */ /* Reset SPI result (note we deliberately don't touch lastoid) */
SPI_processed = 0; SPI_processed = 0;
SPI_tuptable = NULL; SPI_tuptable = NULL;