From 32311dfaa0c6a22b1e7268710167d6a8b7f41181 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 17 Mar 2007 03:15:47 +0000 Subject: [PATCH] SPI_cursor_open failed to enforce that only read-only queries could be executed in read_only mode. This could lead to various relatively-subtle failures, such as an allegedly stable function returning non-stable results. Bug goes all the way back to the introduction of read-only mode in 8.0. Per report from Gaetano Mendola. --- src/backend/executor/spi.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c index a444cb882a..07f312e8a2 100644 --- a/src/backend/executor/spi.c +++ b/src/backend/executor/spi.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/spi.c,v 1.165.2.2 2006/12/26 16:56:22 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/spi.c,v 1.165.2.3 2007/03/17 03:15:47 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -870,6 +870,26 @@ SPI_cursor_open(const char *name, void *plan, if (list_length(qtlist) != list_length(ptlist)) elog(ERROR, "corrupted SPI plan lists"); + /* + * If told to be read-only, we'd better check for read-only queries. + */ + if (read_only) + { + ListCell *lc; + + foreach(lc, qtlist) + { + Query *qry = (Query *) lfirst(lc); + + if (!QueryIsReadOnly(qry)) + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + /* translator: %s is a SQL statement name */ + errmsg("%s is not allowed in a non-volatile function", + CreateQueryTag(qry)))); + } + } + /* Reset SPI result (note we deliberately don't touch lastoid) */ SPI_processed = 0; SPI_tuptable = NULL;