mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-12-21 08:29:39 +08:00
Acquire appropriate locks when rewriting during RMV.
Since the query has not been freshly parsed when executing REFRESH MATERIALIZED VIEW, locks must be explicitly taken before rewrite. Backpatch to 9.3. Andres Freund
This commit is contained in:
parent
be420fa02e
commit
2a781d57dc
@ -283,6 +283,7 @@ refresh_matview_datafill(DestReceiver *dest, Query *query,
|
||||
Oid save_userid;
|
||||
int save_sec_context;
|
||||
int save_nestlevel;
|
||||
Query *copied_query;
|
||||
|
||||
/*
|
||||
* Switch to the owner's userid, so that any functions are run as that
|
||||
@ -294,8 +295,10 @@ refresh_matview_datafill(DestReceiver *dest, Query *query,
|
||||
save_sec_context | SECURITY_RESTRICTED_OPERATION);
|
||||
save_nestlevel = NewGUCNestLevel();
|
||||
|
||||
/* Rewrite, copying the given Query to make sure it's not changed */
|
||||
rewritten = QueryRewrite((Query *) copyObject(query));
|
||||
/* Lock and rewrite, using a copy to preserve the original query. */
|
||||
copied_query = copyObject(query);
|
||||
AcquireRewriteLocks(copied_query, false);
|
||||
rewritten = QueryRewrite(copied_query);
|
||||
|
||||
/* SELECT should never rewrite to more or less than one SELECT query */
|
||||
if (list_length(rewritten) != 1)
|
||||
|
Loading…
Reference in New Issue
Block a user