mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-21 08:29:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't let transform_null_equals=on affect CASE foo WHEN NULL ... constructs.

Browse Source 
transform_null_equals is only supposed to affect "foo = NULL" expressions
given directly by the user, not the internal "foo = NULL" expression
generated from CASE-WHEN.

This fixes bug #6242, reported by Sergey. Backpatch to all supported
branches.
This commit is contained in:
Heikki Linnakangas 2011-10-08 11:17:40 +03:00
parent 041dceb259
commit 1ef60dab70
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/parser/parse_expr.c
View File

@ -836,12 +836,15 @@ transformAExprOp(ParseState *pstate, A_Expr *a)
/* /*
* Special-case "foo = NULL" and "NULL = foo" for compatibility with * Special-case "foo = NULL" and "NULL = foo" for compatibility with
* standards-broken products (like Microsoft's). Turn these into IS NULL * standards-broken products (like Microsoft's). Turn these into IS NULL
* exprs. * exprs. (If either side is a CaseTestExpr, then the expression was
* generated internally from a CASE-WHEN expression, and
* transform_null_equals does not apply.)
*/ */
if (Transform_null_equals && if (Transform_null_equals &&
list_length(a->name) == 1 && list_length(a->name) == 1 &&
strcmp(strVal(linitial(a->name)), "=") == 0 && strcmp(strVal(linitial(a->name)), "=") == 0 &&
(exprIsNullConstant(lexpr) || exprIsNullConstant(rexpr))) (exprIsNullConstant(lexpr) || exprIsNullConstant(rexpr)) &&
(!IsA(lexpr, CaseTestExpr) && !IsA(rexpr, CaseTestExpr)))
{ {
NullTest *n = makeNode(NullTest); NullTest *n = makeNode(NullTest);