mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-27 08:39:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make CREATE DATABASE safe against losing whole files by fsyncing the

Browse Source 
directory and not just the individual files.

Back-patch to 8.1 -- before that we just called "cp -r" and never
fsynced anything anyways.
This commit is contained in:
Greg Stark 2010-02-14 17:50:39 +00:00
parent c53917dc66
commit 1534023ff0
1 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/port/copydir.c
View File

@ -11,7 +11,7 @@
* as a service. * as a service.
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/port/copydir.c,v 1.18.2.1 2008/03/31 01:32:17 tgl Exp $ * $PostgreSQL: pgsql/src/port/copydir.c,v 1.18.2.2 2010/02/14 17:50:39 stark Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -50,6 +50,7 @@ copydir(char *fromdir, char *todir, bool recurse)
{ {
DIR *xldir; DIR *xldir;
struct dirent *xlde; struct dirent *xlde;
int dirfd;
char fromfile[MAXPGPATH]; char fromfile[MAXPGPATH];
char tofile[MAXPGPATH]; char tofile[MAXPGPATH];
@ -91,6 +92,26 @@ copydir(char *fromdir, char *todir, bool recurse)
} }
FreeDir(xldir); FreeDir(xldir);
/*
* fsync the directory to make sure not just the data but also the
* new directory file entries have reached the disk. While needed
* by most filesystems, the window got bigger with newer ones like
* ext4.
*/
dirfd = BasicOpenFile(todir,
O_RDONLY | PG_BINARY,
S_IRUSR | S_IWUSR);
if(dirfd == -1)
ereport(ERROR,
(errcode_for_file_access(),
errmsg("could not open directory for fsync \"%s\": %m", todir)));
if(pg_fsync(dirfd) == -1)
ereport(ERROR,
(errcode_for_file_access(),
errmsg("could not fsync directory \"%s\": %m", todir)));
close(dirfd);
} }
/* /*