mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-21 08:29:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix brain fade in DefineIndex(): it was continuing to access the table's

Browse Source 
relcache entry after having heap_close'd it.  This could lead to misbehavior
if a relcache flush wiped out the cache entry meanwhile.  In 8.2 there is a
very real risk of CREATE INDEX CONCURRENTLY using the wrong relid for locking
and waiting purposes.  I think the bug is only cosmetic in 8.0 and 8.1,
because their transgression is limited to using RelationGetRelationName(rel)
in an ereport message immediately after heap_close, and there's no way (except
with special debugging options) for a cache flush to occur in that interval.
Not quite sure that it's cosmetic in 7.4, but seems best to patch anyway.

Found by trying to run the regression tests with CLOBBER_CACHE_ALWAYS enabled.
Maybe we should try to do that on a regular basis --- it's awfully slow,
but perhaps some fast buildfarm machine could do it once in awhile.
This commit is contained in:
Tom Lane 2007-08-25 19:08:25 +00:00
parent f94c9dbf22
commit 10f4362255
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/commands/indexcmds.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.149 2006/10/04 00:29:51 momjian Exp $ * $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.149.2.1 2007/08/25 19:08:25 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -423,8 +423,6 @@ DefineIndex(RangeVar *heapRelation,
relationId, accessMethodName, accessMethodId, relationId, accessMethodName, accessMethodId,
isconstraint); isconstraint);
heap_close(rel, NoLock);
/* /*
* Report index creation if appropriate (delay this till after most of the * Report index creation if appropriate (delay this till after most of the
* error checks) * error checks)
@ -436,6 +434,10 @@ DefineIndex(RangeVar *heapRelation,
primary ? "PRIMARY KEY" : "UNIQUE", primary ? "PRIMARY KEY" : "UNIQUE",
indexRelationName, RelationGetRelationName(rel)))); indexRelationName, RelationGetRelationName(rel))));
/* save lockrelid for below, then close rel */
heaprelid = rel->rd_lockInfo.lockRelId;
heap_close(rel, NoLock);
indexRelationId = indexRelationId =
index_create(relationId, indexRelationName, indexRelationId, index_create(relationId, indexRelationName, indexRelationId,
indexInfo, accessMethodId, tablespaceId, classObjectId, indexInfo, accessMethodId, tablespaceId, classObjectId,
@ -463,7 +465,6 @@ DefineIndex(RangeVar *heapRelation,
* because there are no operations that could change its state while we * because there are no operations that could change its state while we
* hold lock on the parent table. This might need to change later. * hold lock on the parent table. This might need to change later.
*/ */
heaprelid = rel->rd_lockInfo.lockRelId;
LockRelationIdForSession(&heaprelid, ShareUpdateExclusiveLock); LockRelationIdForSession(&heaprelid, ShareUpdateExclusiveLock);
CommitTransactionCommand(); CommitTransactionCommand();