mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-11-27 07:21:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove our artificial PG_SOMAXCONN limit on listen queue length.

Browse Source 
I added this in commit 153f40067, out of paranoia about kernels
possibly rejecting very large listen backlog requests.  However,
POSIX has said for decades that the kernel must silently reduce
any value it considers too large, and there's no evidence that
any current system doesn't obey that.  Let's just drop this limit
and save some complication.

While we're here, compute the request as twice MaxConnections not
twice MaxBackends; the latter no longer means what it did in 2001.

Per discussion of a report from Kevin McKibbin.

Discussion: https://postgr.es/m/CADc_NKg2d+oZY9mg4DdQdoUcGzN2kOYXBu-3--RW_hEe0tUV=g@mail.gmail.com
This commit is contained in:
Tom Lane 2022-08-23 10:14:45 -04:00
parent ba94dfd4c4
commit 0f47457f11
2 changed files with 4 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/libpq/pqcomm.c
View File

@ -537,13 +537,11 @@ StreamServerPort(int family, const char *hostName, unsigned short portNumber,
} }
/* /*
* Select appropriate accept-queue length limit. PG_SOMAXCONN is only * Select appropriate accept-queue length limit. It seems reasonable
* intended to provide a clamp on the request on platforms where an * to use a value similar to the maximum number of child processes
* overly large request provokes a kernel error (are there any?). * that the postmaster will permit.
*/ */
maxconn = MaxBackends * 2; maxconn = MaxConnections * 2;
if (maxconn > PG_SOMAXCONN)
maxconn = PG_SOMAXCONN;
err = listen(fd, maxconn); err = listen(fd, maxconn);
if (err < 0) if (err < 0)

11
src/include/pg_config_manual.h
View File

@ -114,17 +114,6 @@
*/ */
#define MAXPGPATH 1024 #define MAXPGPATH 1024
/*
* PG_SOMAXCONN: maximum accept-queue length limit passed to
* listen(2). You'd think we should use SOMAXCONN from
* <sys/socket.h>, but on many systems that symbol is much smaller
* than the kernel's actual limit. In any case, this symbol need be
* twiddled only if you have a kernel that refuses large limit values,
* rather than silently reducing the value to what it can handle
* (which is what most if not all Unixen do).
*/
#define PG_SOMAXCONN 10000
/* /*
* You can try changing this if you have a machine with bytes of * You can try changing this if you have a machine with bytes of
* another size, but no guarantee... * another size, but no guarantee...