From 0db343dc13bc8657976c39ddbf7e0c7db8b2efff Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Tue, 26 Oct 2021 11:16:06 +0900 Subject: [PATCH] Fix overly-lax regex pattern in TAP test of READ_REPLICATION_SLOT The case checking for a NULL output when a slot does not exist was too lax, as it was passing for any output generated by the query. This fixes the matching pattern to be what it should be, matching only on "||". Oversight in b4ada4e. --- src/test/recovery/t/001_stream_rep.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/recovery/t/001_stream_rep.pl b/src/test/recovery/t/001_stream_rep.pl index b3dc68d54b..c70c08e27b 100644 --- a/src/test/recovery/t/001_stream_rep.pl +++ b/src/test/recovery/t/001_stream_rep.pl @@ -263,7 +263,7 @@ my $slotname = 'test_read_replication_slot_physical'; 'READ_REPLICATION_SLOT non_existent_slot;', extra_params => [ '-d', $connstr_rep ]); ok($ret == 0, "READ_REPLICATION_SLOT exit code 0 on success"); -like($stdout, qr/^||$/, +like($stdout, qr/^\|\|$/, "READ_REPLICATION_SLOT returns NULL values if slot does not exist"); $node_primary->psql(