mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-21 08:29:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Better error reporting if the link target is too long

Browse Source 
This situation won't set errno, so using %m will give an incorrect
error message.
This commit is contained in:
Magnus Hagander 2011-12-07 12:17:55 +01:00
parent 1f422db663
commit 0d9b09282f
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/utils/adt/misc.c
View File

@ -287,9 +287,12 @@ pg_tablespace_location(PG_FUNCTION_ARGS)
*/ */
snprintf(sourcepath, sizeof(sourcepath), "pg_tblspc/%u", tablespaceOid); snprintf(sourcepath, sizeof(sourcepath), "pg_tblspc/%u", tablespaceOid);
rllen =readlink(sourcepath, targetpath, sizeof(targetpath)); rllen =readlink(sourcepath, targetpath, sizeof(targetpath));
if (rllen < 0 || rllen >= sizeof(targetpath)) if (rllen < 0)
ereport(ERROR, ereport(ERROR,
(errmsg("could not read symbolic link \"%s\": %m", sourcepath))); (errmsg("could not read symbolic link \"%s\": %m", sourcepath)));
else if (rllen >= sizeof(targetpath))
ereport(ERROR,
(errmsg("symbolic link \"%s\" target is too long", sourcepath)));
targetpath[rllen] = '\0'; targetpath[rllen] = '\0';
PG_RETURN_TEXT_P(cstring_to_text(targetpath)); PG_RETURN_TEXT_P(cstring_to_text(targetpath));