mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-11-27 07:21:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix comment in xlogutils.c

Browse Source 
The existing callers of XLogReadDetermineTimeline() performing recovery
need to check a replay LSN position when determining on which timeline
to read a WAL page.  A portion of the comment describing this function
said exactly that, while referring to a routine for fetching a write
LSN, something not available in recovery.

Author: Kyotaro Horiguchi
Discussion: https://postgr.es/m/20200511.101619.2043820539323292957.horikyota.ntt@gmail.com
This commit is contained in:
Michael Paquier 2020-05-12 14:43:57 +09:00
parent 81ec990a23
commit 078c9cd258
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/access/transam/xlogutils.c
View File

@ -681,10 +681,10 @@ XLogTruncateRelation(RelFileNode rnode, ForkNumber forkNum,
* copied to a new timeline. * copied to a new timeline.
* *
* The caller must also make sure it doesn't read past the current replay * The caller must also make sure it doesn't read past the current replay
* position (using GetWalRcvWriteRecPtr) if executing in recovery, so it * position (using GetXLogReplayRecPtr) if executing in recovery, so it
* doesn't fail to notice that the current timeline became historical. The * doesn't fail to notice that the current timeline became historical. The
* caller must also update ThisTimeLineID with the result of * caller must also update ThisTimeLineID with the result of
* GetWalRcvWriteRecPtr and must check RecoveryInProgress(). * GetXLogReplayRecPtr and must check RecoveryInProgress().
*/ */
void void
XLogReadDetermineTimeline(XLogReaderState *state, XLogRecPtr wantPage, uint32 wantLength) XLogReadDetermineTimeline(XLogReaderState *state, XLogRecPtr wantPage, uint32 wantLength)