From 0717f2fedb2400e4f5bf89bcd463c8b32916ca26 Mon Sep 17 00:00:00 2001 From: Jeff Davis Date: Sat, 29 Oct 2022 14:13:23 -0700 Subject: [PATCH] Fix ALTER COLLATION "default" REFRESH VERSION. Issue a helpful error message rather than an internal error. Discussion: https://postgr.es/m/51fb77507cafd43fc1a2e733c23045873d93ae60.camel%40j-davis.com Reviewed-by: Thomas Munro --- src/backend/commands/collationcmds.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/backend/commands/collationcmds.c b/src/backend/commands/collationcmds.c index 23468cf79d..86fbc7fa01 100644 --- a/src/backend/commands/collationcmds.c +++ b/src/backend/commands/collationcmds.c @@ -366,6 +366,11 @@ AlterCollation(AlterCollationStmt *stmt) rel = table_open(CollationRelationId, RowExclusiveLock); collOid = get_collation_oid(stmt->collname, false); + if (collOid == DEFAULT_COLLATION_OID) + ereport(ERROR, + (errmsg("cannot refresh version of default collation"), + errhint("Use ALTER DATABASE ... REFRESH COLLATION VERSION instead."))); + if (!pg_collation_ownercheck(collOid, GetUserId())) aclcheck_error(ACLCHECK_NOT_OWNER, OBJECT_COLLATION, NameListToString(stmt->collname));