From 02d5ab6a86aa941109cecd9e6ebe73a67e8bf545 Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Sun, 23 Nov 2014 13:47:08 -0500 Subject: [PATCH] Fix memory leaks introduced by commit eca2b9b --- src/bin/psql/command.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/bin/psql/command.c b/src/bin/psql/command.c index 162fcf1401..4575e2e796 100644 --- a/src/bin/psql/command.c +++ b/src/bin/psql/command.c @@ -2974,7 +2974,10 @@ lookup_function_oid(const char *desc, Oid *foid) appendPQExpBuffer(query, "::pg_catalog.%s::pg_catalog.oid", strchr(desc, '(') ? "regprocedure" : "regproc"); if (!lookup_function_echo_hidden(query->data)) + { + destroyPQExpBuffer(query); return false; + } res = PQexec(pset.db, query->data); if (PQresultStatus(res) == PGRES_TUPLES_OK && PQntuples(res) == 1) *foid = atooid(PQgetvalue(res, 0, 0)); @@ -3005,7 +3008,10 @@ get_create_function_cmd(Oid oid, PQExpBuffer buf) printfPQExpBuffer(query, "SELECT pg_catalog.pg_get_functiondef(%u)", oid); if (!lookup_function_echo_hidden(query->data)) + { + destroyPQExpBuffer(query); return false; + } res = PQexec(pset.db, query->data); if (PQresultStatus(res) == PGRES_TUPLES_OK && PQntuples(res) == 1) {