2010-09-21 04:08:53 +08:00
|
|
|
# contrib/vacuumlo/Makefile
|
2010-05-12 19:33:10 +08:00
|
|
|
|
|
|
|
|
PGFILEDESC = "vacuumlo - removes orphaned large objects"
|
2011-01-25 09:46:30 +08:00
|
|
|
PGAPPICON = win32
|
1999-04-11 00:48:05 +08:00
|
|
|
|
2001-09-06 18:49:30 +08:00
|
|
|
PROGRAM = vacuumlo
|
2014-07-15 02:07:52 +08:00
|
|
|
OBJS = vacuumlo.o $(WIN32RES)
|
1999-04-11 00:48:05 +08:00
|
|
|
|
2001-09-06 18:49:30 +08:00
|
|
|
PG_CPPFLAGS = -I$(libpq_srcdir)
|
Prevent accidental linking of system-supplied copies of libpq.so etc.
We were being careless in some places about the order of -L switches in
link command lines, such that -L switches referring to external directories
could come before those referring to directories within the build tree.
This made it possible to accidentally link a system-supplied library, for
example /usr/lib/libpq.so, in place of the one built in the build tree.
Hilarity ensued, the more so the older the system-supplied library is.
To fix, break LDFLAGS into two parts, a sub-variable LDFLAGS_INTERNAL
and the main LDFLAGS variable, both of which are "recursively expanded"
so that they can be incrementally adjusted by different makefiles.
Establish a policy that -L switches for directories in the build tree
must always be added to LDFLAGS_INTERNAL, while -L switches for external
directories must always be added to LDFLAGS. This is sufficient to
ensure a safe search order. For simplicity, we typically also put -l
switches for the respective libraries into those same variables.
(Traditional make usage would have us put -l switches into LIBS, but
cleaning that up is a project for another day, as there's no clear
need for it.)
This turns out to also require separating SHLIB_LINK into two variables,
SHLIB_LINK and SHLIB_LINK_INTERNAL, with a similar rule about which
switches go into which variable. And likewise for PG_LIBS.
Although this change might appear to affect external users of pgxs.mk,
I think it doesn't; they shouldn't have any need to touch the _INTERNAL
variables.
In passing, tweak src/common/Makefile so that the value of CPPFLAGS
recorded in pg_config lacks "-DFRONTEND" and the recorded value of
LDFLAGS lacks "-L../../../src/common". Both of those things are
mistakes, apparently introduced during prior code rearrangements,
as old versions of pg_config don't print them. In general we don't
want anything that's specific to the src/common subdirectory to
appear in those outputs.
This is certainly a bug fix, but in view of the lack of field
complaints, I'm unsure whether it's worth the risk of back-patching.
In any case it seems wise to see what the buildfarm makes of it first.
Discussion: https://postgr.es/m/25214.1522604295@sss.pgh.pa.us
2018-04-04 04:26:05 +08:00
|
|
|
PG_LIBS_INTERNAL = $(libpq_pgport)
|
2000-06-16 02:55:34 +08:00
|
|
|
|
2004-08-21 04:13:10 +08:00
|
|
|
ifdef USE_PGXS
|
2007-06-27 06:05:04 +08:00
|
|
|
PG_CONFIG = pg_config
|
|
|
|
|
PGXS := $(shell $(PG_CONFIG) --pgxs)
|
2004-08-21 04:13:10 +08:00
|
|
|
include $(PGXS)
|
|
|
|
|
else
|
|
|
|
|
subdir = contrib/vacuumlo
|
|
|
|
|
top_builddir = ../..
|
|
|
|
|
include $(top_builddir)/src/Makefile.global
|
2001-09-06 18:49:30 +08:00
|
|
|
include $(top_srcdir)/contrib/contrib-global.mk
|
2004-08-21 04:13:10 +08:00
|
|
|
endif
|
2018-08-28 20:42:45 +08:00
|
|
|
|
|
|
|
|
check:
|
|
|
|
|
$(prove_check)
|
|
|
|
|
|
|
|
|
|
installcheck:
|
|
|
|
|
$(prove_installcheck)
|
