mirror of
https://github.com/openssl/openssl.git
synced 2025-01-06 13:26:43 +08:00
5056133cc7
gh_gen_type_common_set_params looks up a dsa contexts gen_type using
name2id, but if it returns error, we inadvertently set gctx->gen_type to
-1, which is an invalid value, which may lead to improper behavior in
future calls, in the event that said future calls preform an operation
of the form;
if (gen_type == <VALID VALUE>) {
do_stuff
else {
do_other_stuff
}
Technically it is not correct to continue with the operations on the
gen context after failed parameters setting but this makes it more
predictable.
Fix it by assigning the result of a lookup to a stack variable, and only
update gctx->gen_value if the lookup returns a non-failing value
In leiu of testing this specific case, also add an ossl_assert in dsa_gen
to validate the gen_val input prior to continuing, should other code
points attempt to do the same thing
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22991)
|
||
|---|---|---|
| .. | ||
| __DECC_INCLUDE_EPILOGUE.H | ||
| __DECC_INCLUDE_PROLOGUE.H | ||
| aes_platform.h | ||
| aria.h | ||
| asn1_dsa.h | ||
| asn1.h | ||
| asn1err.h | ||
| async.h | ||
| asyncerr.h | ||
| bioerr.h | ||
| bn_conf.h.in | ||
| bn_dh.h | ||
| bn_srp.h | ||
| bn.h | ||
| bnerr.h | ||
| buffererr.h | ||
| chacha.h | ||
| cmll_platform.h | ||
| cmperr.h | ||
| cmserr.h | ||
| comperr.h | ||
| conferr.h | ||
| context.h | ||
| crmferr.h | ||
| cryptlib.h | ||
| cryptoerr.h | ||
| cterr.h | ||
| ctype.h | ||
| decoder.h | ||
| decodererr.h | ||
| des_platform.h | ||
| dh.h | ||
| dherr.h | ||
| dsa.h | ||
| dsaerr.h | ||
| dso_conf.h.in | ||
| ec.h | ||
| ecerr.h | ||
| ecx.h | ||
| encoder.h | ||
| encodererr.h | ||
| engine.h | ||
| engineerr.h | ||
| err.h | ||
| ess.h | ||
| esserr.h | ||
| evp.h | ||
| evperr.h | ||
| httperr.h | ||
| lhash.h | ||
| md32_common.h | ||
| modes.h | ||
| objects.h | ||
| objectserr.h | ||
| ocsperr.h | ||
| pem.h | ||
| pemerr.h | ||
| pkcs7.h | ||
| pkcs7err.h | ||
| pkcs12err.h | ||
| poly1305.h | ||
| ppc_arch.h | ||
| punycode.h | ||
| rand_pool.h | ||
| rand.h | ||
| randerr.h | ||
| riscv_arch.def | ||
| riscv_arch.h | ||
| rsa.h | ||
| rsaerr.h | ||
| security_bits.h | ||
| sha.h | ||
| siphash.h | ||
| siv.h | ||
| sm2.h | ||
| sm2err.h | ||
| sm4_platform.h | ||
| sm4.h | ||
| sparc_arch.h | ||
| sparse_array.h | ||
| store.h | ||
| storeerr.h | ||
| tserr.h | ||
| types.h | ||
| uierr.h | ||
| x509.h | ||
| x509err.h | ||
| x509v3err.h | ||