mirror of
https://github.com/openssl/openssl.git
synced 2025-01-18 13:44:20 +08:00
e3d0dae7cf
The existing implementation of DTLSv1_listen() is fundamentally flawed. This function is used in DTLS solutions to listen for new incoming connections from DTLS clients. A client will send an initial ClientHello. The server will respond with a HelloVerifyRequest containing a unique cookie. The client the responds with a second ClientHello - which this time contains the cookie. Once the cookie has been verified then DTLSv1_listen() returns to user code, which is typically expected to continue the handshake with a call to (for example) SSL_accept(). Whilst listening for incoming ClientHellos, the underlying BIO is usually in an unconnected state. Therefore ClientHellos can come in from *any* peer. The arrival of the first ClientHello without the cookie, and the second one with it, could be interspersed with other intervening messages from different clients. The whole purpose of this mechanism is as a defence against DoS attacks. The idea is to avoid allocating state on the server until the client has verified that it is capable of receiving messages at the address it claims to come from. However the existing DTLSv1_listen() implementation completely fails to do this. It attempts to super-impose itself on the standard state machine and reuses all of this code. However the standard state machine expects to operate in a stateful manner with a single client, and this can cause various problems. A second more minor issue is that the return codes from this function are quite confused, with no distinction made between fatal and non-fatal errors. Most user code treats all errors as non-fatal, and simply retries the call to DTLSv1_listen(). This commit completely rewrites the implementation of DTLSv1_listen() and provides a stand alone implementation that does not rely on the existing state machine. It also provides more consistent return codes. Reviewed-by: Andy Polyakov <appro@openssl.org> |
||
|---|---|---|
| .. | ||
| record | ||
| bio_ssl.c | ||
| d1_both.c | ||
| d1_clnt.c | ||
| d1_lib.c | ||
| d1_meth.c | ||
| d1_msg.c | ||
| d1_srtp.c | ||
| d1_srvr.c | ||
| install-ssl.com | ||
| Makefile | ||
| packet_locl.h | ||
| s3_both.c | ||
| s3_cbc.c | ||
| s3_clnt.c | ||
| s3_enc.c | ||
| s3_lib.c | ||
| s3_msg.c | ||
| s3_srvr.c | ||
| ssl_algs.c | ||
| ssl_asn1.c | ||
| ssl_cert.c | ||
| ssl_ciph.c | ||
| ssl_conf.c | ||
| ssl_err2.c | ||
| ssl_err.c | ||
| ssl_lib.c | ||
| ssl_locl.h | ||
| ssl_rsa.c | ||
| ssl_sess.c | ||
| ssl_stat.c | ||
| ssl_txt.c | ||
| ssl_utst.c | ||
| ssl-lib.com | ||
| t1_clnt.c | ||
| t1_enc.c | ||
| t1_ext.c | ||
| t1_lib.c | ||
| t1_meth.c | ||
| t1_reneg.c | ||
| t1_srvr.c | ||
| t1_trce.c | ||
| tls_srp.c | ||