mirror of
https://github.com/openssl/openssl.git
synced 2025-01-18 13:44:20 +08:00
de53817ec3
ossl_policy_level_add_node() first adds the new node to the level->nodes stack, and then attempts to add extra data if extra_data is true. If memory allocation or adding the extra data to tree->extra_data fails, the allocated node (that has already been added to the level->nodes stack) is freed using ossl_policy_node_free(), which leads to a potential use after free. Additionally, the tree's node count and the parent's child count would not be updated, despite the new node being added. Fix this by either performing the function's purpose completely, or not at all by reverting the changes on error. Signed-off-by: Clemens Lang <cllang@redhat.com> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/21040) |
||
|---|---|---|
| .. | ||
| build.info | ||
| by_dir.c | ||
| by_file.c | ||
| by_store.c | ||
| ext_dat.h | ||
| pcy_cache.c | ||
| pcy_data.c | ||
| pcy_lib.c | ||
| pcy_local.h | ||
| pcy_map.c | ||
| pcy_node.c | ||
| pcy_tree.c | ||
| standard_exts.h | ||
| t_crl.c | ||
| t_req.c | ||
| t_x509.c | ||
| v3_addr.c | ||
| v3_admis.c | ||
| v3_admis.h | ||
| v3_akeya.c | ||
| v3_akid.c | ||
| v3_asid.c | ||
| v3_bcons.c | ||
| v3_bitst.c | ||
| v3_conf.c | ||
| v3_cpols.c | ||
| v3_crld.c | ||
| v3_enum.c | ||
| v3_extku.c | ||
| v3_genn.c | ||
| v3_ia5.c | ||
| v3_info.c | ||
| v3_int.c | ||
| v3_ist.c | ||
| v3_lib.c | ||
| v3_ncons.c | ||
| v3_pci.c | ||
| v3_pcia.c | ||
| v3_pcons.c | ||
| v3_pku.c | ||
| v3_pmaps.c | ||
| v3_prn.c | ||
| v3_purp.c | ||
| v3_san.c | ||
| v3_skid.c | ||
| v3_sxnet.c | ||
| v3_tlsf.c | ||
| v3_utf8.c | ||
| v3_utl.c | ||
| v3err.c | ||
| x509_att.c | ||
| x509_cmp.c | ||
| x509_d2.c | ||
| x509_def.c | ||
| x509_err.c | ||
| x509_ext.c | ||
| x509_local.h | ||
| x509_lu.c | ||
| x509_meth.c | ||
| x509_obj.c | ||
| x509_r2x.c | ||
| x509_req.c | ||
| x509_set.c | ||
| x509_trust.c | ||
| x509_txt.c | ||
| x509_v3.c | ||
| x509_vfy.c | ||
| x509_vpm.c | ||
| x509cset.c | ||
| x509name.c | ||
| x509rset.c | ||
| x509spki.c | ||
| x509type.c | ||
| x_all.c | ||
| x_attrib.c | ||
| x_crl.c | ||
| x_exten.c | ||
| x_name.c | ||
| x_pubkey.c | ||
| x_req.c | ||
| x_x509.c | ||
| x_x509a.c | ||