openssl/crypto
Simo Sorce d4d89a0762 Fix input checks wrt legacy code
In all legacy code ctx->cipher is dereferenced without checks, so it
makes no sense to jump there is ctx->cipher is NULL as it will just lead
to a crash. Catch it separately and return an error.

This is simlar to the fix in d2c2e49eab

Signed-off-by: Simo Sorce <simo@redhat.com>

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/9002)
2019-05-27 08:05:36 +10:00
..
aes Revert "ppc assembly pack: always increment CTR IV as quadword" 2019-05-20 18:08:42 +10:00
aria Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
asn1 Coverity CID 1444959: Integer handling issues 2019-05-08 09:52:58 +10:00
async add an additional async notification communication method based on callback 2019-01-27 12:27:17 +00:00
bf Following the license change, modify the boilerplates in crypto/bf/ 2018-12-06 14:27:41 +01:00
bio Add testing of RDONLY memory BIOs 2019-04-16 10:50:30 +01:00
blake2 fix truncation of integers on 32bit AIX 2019-03-11 14:45:18 +01:00
bn Call RSA generation callback at the correct time. 2019-04-15 22:37:48 +02:00
buffer Following the license change, modify the boilerplates in crypto/buffer/ 2018-12-06 14:32:34 +01:00
camellia Following the license change, modify the boilerplates in crypto/camellia/ 2018-12-06 14:34:55 +01:00
cast Following the license change, modify the boilerplates in crypto/cast/ 2018-12-06 14:36:10 +01:00
chacha s390x assembly pack: remove chacha20 dependency on non-base memnonics 2019-04-25 23:07:36 +02:00
cmac Following the license change, modify the boilerplates in crypto/cmac/ 2018-12-06 14:39:25 +01:00
cms Change arg to cms_CompressedData_init_bio to be const 2019-03-08 16:06:26 +00:00
comp Following the license change, modify the boilerplates in crypto/comp/ 2018-12-06 14:42:18 +01:00
conf Coverity: fix two minor NPD issues. 2019-04-06 19:16:59 +10:00
crmf replace 'OpenSSL license' by 'Apache License 2.0' 2019-03-20 10:33:39 +02:00
ct Following the license change, modify the boilerplates in crypto/ct/ 2018-12-06 14:44:27 +01:00
des Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
dh Change default RSA, DSA and DH size to 2048 bit 2019-05-21 16:44:02 +02:00
dsa EVP_Digest*: enable SHA3 pre-hashing for DSA 2019-05-22 16:49:49 +02:00
dso Rework DSO API conditions and configuration option 2019-04-01 06:14:50 +02:00
ec EVP_Digest*: enable SHA3 pre-hashing for ECDSA 2019-05-22 16:49:45 +02:00
engine Coverity CID 1444957: Error handling issues 2019-05-08 09:52:58 +10:00
err Clear CRMF vs CMP confusion 2019-05-20 16:19:00 +02:00
ess constify *_dup() and *i2d_*() and related functions as far as possible, introducing DECLARE_ASN1_DUP_FUNCTION 2019-03-06 16:10:09 +00:00
evp Fix input checks wrt legacy code 2019-05-27 08:05:36 +10:00
gmac Following the license change, modify the boilerplates in crypto/gmac/ 2018-12-06 15:00:48 +01:00
hmac Don't allow SHAKE128/SHAKE256 with HMAC 2019-03-27 14:32:08 +00:00
idea Following the license change, modify the boilerplates in crypto/idea/ 2018-12-06 14:56:39 +01:00
include/internal Added X963KDF API 2019-05-16 11:43:41 +10:00
kdf Cleaned up tls1_prf and added comments. 2019-05-24 10:39:18 +10:00
kmac Update kmac.c 2018-12-08 11:00:18 +01:00
lhash Make some EVP code available from within the FIPS module 2019-05-23 11:02:04 +01:00
md2 Following the license change, modify the boilerplates in crypto/mdN/ 2018-12-06 15:04:11 +01:00
md4 Following the license change, modify the boilerplates in crypto/mdN/ 2018-12-06 15:04:11 +01:00
md5 Following the license change, modify the boilerplates in crypto/mdN/ 2018-12-06 15:04:11 +01:00
mdc2 Following the license change, modify the boilerplates in crypto/mdc2/ 2018-12-06 15:04:57 +01:00
modes Enforce a strict output length check in CRYPTO_ccm128_tag 2019-04-25 10:44:18 +01:00
objects Fix GOST OID 2019-05-22 19:41:09 +03:00
ocsp Make OCSP_id_cmp and OCSP_id_issuer_cmp accept const params 2019-03-28 09:56:05 +00:00
pem Fix the allocation size in EVP_OpenInit and PEM_SignFinal 2019-04-06 10:17:19 +02:00
perlasm s390x assembly pack: update perlasm module 2019-04-25 23:07:36 +02:00
pkcs7 constify *_dup() and *i2d_*() and related functions as far as possible, introducing DECLARE_ASN1_DUP_FUNCTION 2019-03-06 16:10:09 +00:00
pkcs12 constify *_dup() and *i2d_*() and related functions as far as possible, introducing DECLARE_ASN1_DUP_FUNCTION 2019-03-06 16:10:09 +00:00
poly1305 s390x assembly pack: remove poly1305 dependency on non-base memnonics 2019-04-25 23:07:36 +02:00
property Make some EVP code available from within the FIPS module 2019-05-23 11:02:04 +01:00
rand Ignore entropy from RAND_add()/RAND_seed() in FIPS mode 2019-05-10 07:22:05 +02:00
rc2 Following the license change, modify the boilerplates in crypto/rcN/ 2018-12-06 15:14:57 +01:00
rc4 Build: correct assembler generation in crypto/rc4/build.info 2019-02-04 21:34:32 +01:00
rc5 Following the license change, modify the boilerplates in crypto/rcN/ 2018-12-06 15:14:57 +01:00
ripemd Following the license change, modify the boilerplates in crypto/ripemd/ 2018-12-06 15:15:42 +01:00
rsa Change default RSA, DSA and DH size to 2048 bit 2019-05-21 16:44:02 +02:00
seed Following the license change, modify the boilerplates in crypto/seed/ 2018-12-06 15:22:15 +01:00
sha ARM64 assembly pack: add ThunderX2 results. 2019-04-17 21:08:13 +02:00
siphash Following the license change, modify the boilerplates in crypto/siphash/ 2018-12-06 15:24:02 +01:00
sm2 Support SM2 certificate verification 2019-03-13 15:29:39 +08:00
sm3 Following the license change, modify the boilerplates in crypto/smN/ 2018-12-06 15:24:52 +01:00
sm4 Following the license change, modify the boilerplates in crypto/smN/ 2018-12-06 15:24:52 +01:00
srp Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
stack Make core code available within the FIPS module 2019-05-23 11:02:04 +01:00
store Following the license change, modify the boilerplates in crypto/store/ 2018-12-06 15:27:43 +01:00
ts constify *_dup() and *i2d_*() and related functions as far as possible, introducing DECLARE_ASN1_DUP_FUNCTION 2019-03-06 16:10:09 +00:00
txt_db Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
ui Cleanup vxworks support to be able to compile for VxWorks 7 2019-01-24 17:55:04 +01:00
whrlpool Following the license change, modify the boilerplates in crypto/whrlpool/ 2018-12-06 15:29:22 +01:00
x509 Make X509_set_sm2_id consistent with other setters 2019-04-09 20:44:42 +08:00
x509v3 issue-8973: Added const to parameters for values that were not altered 2019-05-24 13:20:00 +10:00
alphacpuid.pl Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
arm64cpuid.pl Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
arm_arch.h Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
armcap.c crypto/armcap.c, crypto/ppccap.c: stricter use of getauxval() 2019-01-16 18:00:48 +01:00
armv4cpuid.pl ARM assembly pack: make it Windows-friendly. 2019-02-16 16:59:23 +01:00
bsearch.c ossl_bsearch(): New generic internal binary search utility function 2019-05-08 16:17:16 +02:00
build.info Make some EVP code available from within the FIPS module 2019-05-23 11:02:04 +01:00
c64xpluscpuid.pl Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
context.c Make core code available within the FIPS module 2019-05-23 11:02:04 +01:00
core_fetch.c EVP_FETCH: deal with names without pre-defined NIDs 2019-05-12 13:43:38 -07:00
core_namemap.c Create internal number<->name mapping API 2019-05-12 13:43:38 -07:00
cpt_err.c Instead of global data store it in an OPENSSL_CTX 2019-05-02 22:42:09 +01:00
cryptlib.c Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
ctype.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
cversion.c Add the possibility to display and use MODULESDIR 2019-04-23 15:50:35 +02:00
dllmain.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
ebcdic.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
ex_data.c Coverity CID 1444951: Null pointer dereferences 2019-05-08 09:52:58 +10:00
getenv.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
ia64cpuid.S Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
info.c Add a way for the application to get OpenSSL configuration data 2019-04-23 15:51:39 +02:00
init.c Added EVP_KDF (similiar to the EVP_MAC) 2019-05-03 17:52:50 +02:00
LPdir_nyi.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
LPdir_unix.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
LPdir_vms.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
LPdir_win32.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
LPdir_win.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
LPdir_wince.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
mem_clr.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
mem_dbg.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
mem_sec.c Use vxRandLib for VxWorks7 2019-05-02 23:32:44 +02:00
mem.c Create a FIPS provider and put SHA256 in it 2019-04-04 23:09:47 +01:00
mips_arch.h Fix compiling error for mips32r6 and mips64r6 2019-03-19 07:36:21 +01:00
o_dir.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
o_fips.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
o_fopen.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
o_init.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
o_str.c openssl_strerror_r: Fix handling of GNU strerror_r 2019-03-04 10:06:54 +00:00
o_time.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
params.c Params conversion tests. 2019-05-21 07:42:54 +10:00
pariscid.pl Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
ppc_arch.h PPC: Try out if mftb works before using it 2019-01-21 15:42:04 +01:00
ppccap.c crypto/ppccap.c: Fix which hwcap value used to check for HWCAP_ARCH_3_00 2019-05-09 14:19:46 +10:00
ppccpuid.pl PPC: Try out if mftb works before using it 2019-01-21 15:42:04 +01:00
provider_conf.c Rename the PROVIDER_CONF trace to CONF 2019-04-05 12:50:55 +02:00
provider_core.c Add more commentary about recursive Provider intialisation in the FIPS module 2019-05-23 11:02:19 +01:00
provider_local.h Replumbing: Add a mechanism to pre-populate the provider store 2019-03-19 14:06:58 +01:00
provider_predefined.c Make core code available within the FIPS module 2019-05-23 11:02:04 +01:00
provider.c Replumbing: New public API to load or add providers 2019-03-11 20:40:13 +01:00
README.sparse_array Add sparse array data type. 2019-02-12 21:07:29 +10:00
s390x_arch.h Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
s390xcap.c fix --strict-warnings build 2019-04-07 13:48:15 +02:00
s390xcpuid.pl Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
sparc_arch.h Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
sparccpuid.S Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
sparcv9cap.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
sparse_array.c Make the sparse array code use ossl_uintmax_t as its index rather than size_t. 2019-03-06 13:50:54 +10:00
threads_none.c Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
threads_pthread.c Make core code available within the FIPS module 2019-05-23 11:02:04 +01:00
threads_win.c Avoid linking error for InitializeCriticalSectionAndSpinCount(). 2019-03-29 09:51:24 +00:00
trace.c Convert the ENGINE_CONF trace calls to use CONF instead 2019-04-05 12:50:55 +02:00
uid.c crypto/uid.c: use own macro as guard rather than AT_SECURE 2019-01-16 06:19:17 +01:00
vms_rms.h Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
x86_64cpuid.pl Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00
x86cpuid.pl Following the license change, modify the boilerplates in crypto/ 2018-12-06 15:32:17 +01:00

The sparse_array.c file contains an implementation of a sparse array that
attempts to be both space and time efficient.

The sparse array is represented using a tree structure.  Each node in the
tree contains a block of pointers to either the user supplied leaf values or
to another node.

There are a number of parameters used to define the block size:

    OPENSSL_SA_BLOCK_BITS   Specifies the number of bits covered by each block
    SA_BLOCK_MAX            Specifies the number of pointers in each block
    SA_BLOCK_MASK           Specifies a bit mask to perform modulo block size
    SA_BLOCK_MAX_LEVELS     Indicates the maximum possible height of the tree

These constants are inter-related:
    SA_BLOCK_MAX        = 2 ^ OPENSSL_SA_BLOCK_BITS
    SA_BLOCK_MASK       = SA_BLOCK_MAX - 1
    SA_BLOCK_MAX_LEVELS = number of bits in size_t divided by
                          OPENSSL_SA_BLOCK_BITS rounded up to the next multiple
                          of OPENSSL_SA_BLOCK_BITS

OPENSSL_SA_BLOCK_BITS can be defined at compile time and this overrides the
built in setting.

As a space and performance optimisation, the height of the tree is usually
less than the maximum possible height.  Only sufficient height is allocated to
accommodate the largest index added to the data structure.

The largest index used to add a value to the array determines the tree height:

        +----------------------+---------------------+
        | Largest Added Index  |   Height of Tree    |
        +----------------------+---------------------+
        | SA_BLOCK_MAX     - 1 |          1          |
        | SA_BLOCK_MAX ^ 2 - 1 |          2          |
        | SA_BLOCK_MAX ^ 3 - 1 |          3          |
        | ...                  |          ...        |
        | size_t max           | SA_BLOCK_MAX_LEVELS |
        +----------------------+---------------------+

The tree height is dynamically increased as needed based on additions.

An empty tree is represented by a NULL root pointer.  Inserting a value at
index 0 results in the allocation of a top level node full of null pointers
except for the single pointer to the user's data (N = SA_BLOCK_MAX for
breviety):

        +----+
        |Root|
        |Node|
        +-+--+
          |
          |
          |
          v
        +-+-+---+---+---+---+
        | 0 | 1 | 2 |...|N-1|
        |   |nil|nil|...|nil|
        +-+-+---+---+---+---+
          |
          |
          |
          v
        +-+--+
        |User|
        |Data|
        +----+
    Index 0


Inserting at element 2N+1 creates a new root node and pushes down the old root
node.  It then creates a second second level node to hold the pointer to the
user's new data:

        +----+
        |Root|
        |Node|
        +-+--+
          |
          |
          |
          v
        +-+-+---+---+---+---+
        | 0 | 1 | 2 |...|N-1|
        |   |nil|   |...|nil|
        +-+-+---+-+-+---+---+
          |       |
          |       +------------------+
          |                          |
          v                          v
        +-+-+---+---+---+---+      +-+-+---+---+---+---+
        | 0 | 1 | 2 |...|N-1|      | 0 | 1 | 2 |...|N-1|
        |nil|   |nil|...|nil|      |nil|   |nil|...|nil|
        +-+-+---+---+---+---+      +---+-+-+---+---+---+
          |                              |
          |                              |
          |                              |
          v                              v
        +-+--+                         +-+--+
        |User|                         |User|
        |Data|                         |Data|
        +----+                         +----+
    Index 0                       Index 2N+1


The nodes themselves are allocated in a sparse manner.  Only nodes which exist
along a path from the root of the tree to an added leaf will be allocated.
The complexity is hidden and nodes are allocated on an as needed basis.
Because the data is expected to be sparse this doesn't result in a large waste
of space.

Values can be removed from the sparse array by setting their index position to
NULL.  The data structure does not attempt to reclaim nodes or reduce the
height of the tree on removal.  For example, now setting index 0 to NULL would
result in:

        +----+
        |Root|
        |Node|
        +-+--+
          |
          |
          |
          v
        +-+-+---+---+---+---+
        | 0 | 1 | 2 |...|N-1|
        |   |nil|   |...|nil|
        +-+-+---+-+-+---+---+
          |       |
          |       +------------------+
          |                          |
          v                          v
        +-+-+---+---+---+---+      +-+-+---+---+---+---+
        | 0 | 1 | 2 |...|N-1|      | 0 | 1 | 2 |...|N-1|
        |nil|nil|nil|...|nil|      |nil|   |nil|...|nil|
        +---+---+---+---+---+      +---+-+-+---+---+---+
                                         |
                                         |
                                         |
                                         v
                                       +-+--+
                                       |User|
                                       |Data|
                                       +----+
                                  Index 2N+1


Accesses to elements in the sparse array take O(log n) time where n is the
largest element.  The base of the logarithm is SA_BLOCK_MAX, so for moderately
small indices (e.g. NIDs), single level (constant time) access is achievable.
Space usage is O(minimum(m, n log(n)) where m is the number of elements in the
array.

Note: sparse arrays only include pointers to types.  Thus, SPARSE_ARRAY_OF(char)
can be used to store a string.