openssl/apps
Benjamin Kaduk c39e4048b5 Do not set a nonzero default max_early_data
When early data support was first added, this seemed like a good
idea, as it would allow applications to just add SSL_read_early_data()
calls as needed and have things "Just Work".  However, for applications
that do not use TLS 1.3 early data, there is a negative side effect.
Having a nonzero max_early_data in a SSL_CTX (and thus, SSL objects
derived from it) means that when generating a session ticket,
tls_construct_stoc_early_data() will indicate to the client that
the server supports early data.  This is true, in that the implementation
of TLS 1.3 (i.e., OpenSSL) does support early data, but does not
necessarily indicate that the server application supports early data,
when the default value is nonzero.  In this case a well-intentioned
client would send early data along with its resumption attempt, which
would then be ignored by the server application, a waste of network
bandwidth.

Since, in order to successfully use TLS 1.3 early data, the application
must introduce calls to SSL_read_early_data(), it is not much additional
burden to require that the application also calls
SSL_{CTX_,}set_max_early_data() in order to enable the feature; doing
so closes this scenario where early data packets would be sent on
the wire but ignored.

Update SSL_read_early_data.pod accordingly, and make s_server and
our test programs into applications that are compliant with the new
requirements on applications that use early data.

Fixes #4725

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5483)
2018-02-28 21:47:09 -06:00
..
demoSRP
app_rand.c Fix use-after-free 2017-07-17 07:46:49 -04:00
apps.c Add VMS version of app_dirname() 2018-02-28 18:48:04 +01:00
apps.h Check directory is able to create files for various -out option 2018-02-28 18:44:56 +01:00
asn1pars.c Update copyright year 2018-02-13 13:59:25 +00:00
bf_prefix.c Fix of prefix bio filter (bf_prefix.c): rely on the given length 2018-02-01 22:09:41 +01:00
build.info Add an apps internal BIO filter for prefixing output lines 2018-02-01 07:10:47 +01:00
ca-cert.srl
ca-key.pem
ca-req.pem
ca.c do_body: fix heap-use-after-free. 2018-02-21 12:18:56 +00:00
CA.pl.in Adjusted Argument Indices 2017-12-03 14:01:39 +01:00
cert.pem
ciphers.c Update copyright year 2018-02-13 13:59:25 +00:00
client.pem
cms.c apps: Don't include progs.h in apps.h 2018-01-31 23:45:12 +01:00
crl2p7.c Update copyright year 2018-02-13 13:59:25 +00:00
crl.c Update copyright year 2018-02-13 13:59:25 +00:00
ct_log_list.cnf GH1536: Install empty CT log list 2016-09-14 18:22:33 -04:00
dgst.c Update copyright year 2018-02-13 13:59:25 +00:00
dh1024.pem
dh2048.pem
dh4096.pem
dhparam.c Update copyright year 2018-02-13 13:59:25 +00:00
dsa512.pem
dsa1024.pem
dsa-ca.pem
dsa-pca.pem
dsa.c Update copyright year 2018-02-13 13:59:25 +00:00
dsap.pem
dsaparam.c Update copyright year 2018-02-13 13:59:25 +00:00
ec.c Update copyright year 2018-02-13 13:59:25 +00:00
ecparam.c Update copyright year 2018-02-13 13:59:25 +00:00
enc.c Add support for PBKDF2 for enc command 2018-02-21 12:36:21 +00:00
engine.c Update copyright year 2018-02-13 13:59:25 +00:00
errstr.c Update copyright year 2018-02-13 13:59:25 +00:00
gendsa.c Update copyright year 2018-02-13 13:59:25 +00:00
genpkey.c Update copyright year 2018-02-13 13:59:25 +00:00
genrsa.c Fix the type of -out option 2018-02-28 18:44:56 +01:00
nseq.c Update copyright year 2018-02-13 13:59:25 +00:00
ocsp.c ocsp.c doesn't free the whole output chain, maybe causing a memory leak 2018-02-01 07:10:48 +01:00
openssl-vms.cnf Added support for ESSCertIDv2 2017-05-03 09:04:23 +02:00
openssl.c initialise dc variable to satisfy old compilers. 2018-02-22 13:54:27 -05:00
openssl.cnf Added support for ESSCertIDv2 2017-05-03 09:04:23 +02:00
opt.c Check on VMS as well 2018-02-28 18:48:04 +01:00
passwd.c Update copyright year 2018-02-13 13:59:25 +00:00
pca-cert.srl
pca-key.pem
pca-req.pem
pkcs7.c Update copyright year 2018-02-13 13:59:25 +00:00
pkcs8.c Update copyright year 2018-02-13 13:59:25 +00:00
pkcs12.c Update copyright year 2018-02-13 13:59:25 +00:00
pkey.c Update copyright year 2018-02-13 13:59:25 +00:00
pkeyparam.c Update copyright year 2018-02-13 13:59:25 +00:00
pkeyutl.c Update copyright year 2018-02-13 13:59:25 +00:00
prime.c Update copyright year 2018-02-13 13:59:25 +00:00
privkey.pem
progs.pl Copyright update of more files that have changed this year 2018-01-19 13:34:03 +01:00
rand.c Update copyright year 2018-02-13 13:59:25 +00:00
rehash.c Update copyright year 2018-02-13 13:59:25 +00:00
req.c Update copyright year 2018-02-13 13:59:25 +00:00
req.pem
rsa8192.pem
rsa.c Update copyright year 2018-02-13 13:59:25 +00:00
rsautl.c Update copyright year 2018-02-13 13:59:25 +00:00
s512-key.pem
s512-req.pem
s1024key.pem
s1024req.pem
s_apps.h Update copyright year 2018-02-27 13:59:42 +00:00
s_cb.c Update copyright year 2018-02-13 13:59:25 +00:00
s_client.c Add BIO_bind function to bind local address for a socket. 2018-02-19 22:58:37 +01:00
s_server.c Do not set a nonzero default max_early_data 2018-02-28 21:47:09 -06:00
s_socket.c Add BIO_bind function to bind local address for a socket. 2018-02-19 22:58:37 +01:00
s_time.c Update copyright year 2018-02-13 13:59:25 +00:00
server2.pem
server.pem
server.srl
sess_id.c Fix the type of -out option 2018-02-28 18:44:56 +01:00
smime.c Update copyright year 2018-02-13 13:59:25 +00:00
speed.c apps: Don't include progs.h in apps.h 2018-01-31 23:45:12 +01:00
spkac.c Update copyright year 2018-02-13 13:59:25 +00:00
srp.c Update copyright year 2018-02-13 13:59:25 +00:00
storeutl.c storeutl: make sure s2i_ASN1_INTEGER is correctly declared 2018-02-28 18:40:08 +01:00
testCA.pem
testdsa.h Clean up a bundle of codingstyle stuff in apps directory 2017-06-12 16:11:05 -04:00
testrsa.h
timeouts.h
ts.c Update copyright year 2018-02-13 13:59:25 +00:00
tsget.in Cleanup some copyright stuff 2017-06-30 21:56:44 -04:00
verify.c Update copyright year 2018-02-13 13:59:25 +00:00
version.c Update copyright year 2018-02-13 13:59:25 +00:00
vms_decc_init.c
vms_term_sock.c Consistent formatting for sizeof(foo) 2017-12-07 19:11:49 -05:00
vms_term_sock.h Cleanup some copyright stuff 2017-06-30 21:56:44 -04:00
win32_init.c Fix not-c code 2016-10-19 00:56:48 +02:00
x509.c Update copyright year 2018-02-13 13:59:25 +00:00