Go to file
Viktor Dukhovni c0a445a9f2 Suppress DANE TLSA reflection when verification fails
As documented both SSL_get0_dane_authority() and SSL_get0_dane_tlsa()
are expected to return a negative match depth and nothing else when
verification fails.  However, this only happened when verification
failed during chain construction.  Errors in verification of the
constructed chain did not have the intended effect on these functions.

This commit updates the functions to check for verify_result ==
X509_V_OK, and no longer erases any accumulated match information
when chain construction fails.  Sophisticated developers can, with
care, use SSL_set_verify_result(ssl, X509_V_OK) to "peek" at TLSA
info even when verification fail.  They must of course first check
and save the real error, and restore the original error as quickly
as possible.  Hiding by default seems to be the safer interface.

Introduced X509_V_ERR_DANE_NO_MATCH code to signal failure to find
matching TLSA records.  Previously reported via X509_V_ERR_CERT_UNTRUSTED.

This also changes the "-brief" output from s_client to include
verification results and TLSA match information.

Mentioned session resumption in code example in SSL_CTX_dane_enable(3).
Also mentioned that depths returned are relative to the verified chain
which is now available via SSL_get0_verified_chain(3).

Added a few more test-cases to danetest, that exercise the new
code.

Resolved thread safety issue in use of static buffer in
X509_verify_cert_error_string().

Fixed long-stating issue in apps/s_cb.c which always sets verify_error
to either X509_V_OK or "chain to long", code elsewhere (e.g.
s_time.c), seems to expect the actual error.  [ The new chain
construction code is expected to correctly generate "chain
too long" errors, so at some point we need to drop the
work-arounds, once SSL_set_verify_depth() is also fixed to
propagate the depth to X509_STORE_CTX reliably. ]

Reviewed-by: Rich Salz <rsalz@openssl.org>
2016-02-08 14:46:09 -05:00
apps Suppress DANE TLSA reflection when verification fails 2016-02-08 14:46:09 -05:00
certs Fix verify(1) to report failure when verification fails 2016-01-13 17:55:17 -05:00
Configurations Configurations/00-base-templates.conf: harmonize extensions. 2016-02-08 15:53:22 +01:00
crypto Suppress DANE TLSA reflection when verification fails 2016-02-08 14:46:09 -05:00
demos GH601: Various spelling fixes. 2016-02-05 15:25:50 -05:00
doc Suppress DANE TLSA reflection when verification fails 2016-02-08 14:46:09 -05:00
engines Enhance and clear the support of linker flags 2016-02-06 17:57:19 +01:00
external/perl Change the transfer perl module so the real module gets properly registered 2016-02-04 19:44:03 +01:00
include Suppress DANE TLSA reflection when verification fails 2016-02-08 14:46:09 -05:00
ms Fix various windows compilation issues 2015-01-28 22:55:15 +00:00
Netware GH601: Various spelling fixes. 2016-02-05 15:25:50 -05:00
os2
ssl Suppress DANE TLSA reflection when verification fails 2016-02-08 14:46:09 -05:00
test Suppress DANE TLSA reflection when verification fails 2016-02-08 14:46:09 -05:00
tools unified build scheme: add build.info files 2016-02-01 12:46:58 +01:00
util make update 2016-02-08 18:43:49 +00:00
VMS Remove the old VMS linker option file creator for shlibs 2016-01-07 21:09:43 +01:00
.gitignore Templatize util/domd 2016-01-29 16:56:07 -05:00
.travis-create-release.sh Configure first in travis create release 2016-01-26 08:26:27 +01:00
.travis.yml Add more components to build. 2016-01-28 14:48:14 -05:00
ACKNOWLEDGEMENTS Refer to website for acknowledgements. 2015-12-08 16:07:09 -05:00
appveyor.yml Add initial AppVeyor configuration 2015-11-21 18:06:31 +01:00
build.info unified build scheme: add build.info files 2016-02-01 12:46:58 +01:00
CHANGES GH601: Various spelling fixes. 2016-02-05 15:25:50 -05:00
config unified build scheme: a first introduction 2016-02-01 12:46:58 +01:00
Configure Use File::Path::mkpath rather than File::Path::make_path 2016-02-08 17:03:37 +01:00
CONTRIBUTING Ask for tests in CONTRIBUTING 2016-01-25 17:12:57 -05:00
e_os.h Refactoring BIO: add wrappers around sockaddr et al 2016-02-03 19:37:07 +01:00
FAQ Move FAQ to the web. 2015-08-16 19:02:29 -04:00
GitConfigure Remove remaining variables for symlinked/copied headers and tests 2015-03-31 20:16:01 +02:00
GitMake
INSTALL Refactor file writing - information on our use of Perl and Perl modules 2016-01-22 23:12:22 +01:00
install.com
INSTALL.DJGPP Refactor file writing - information on our use of Perl and Perl modules 2016-01-22 23:12:22 +01:00
INSTALL.NW
INSTALL.OS2
INSTALL.VMS Add a few notes on perl 2015-09-15 13:14:49 +02:00
INSTALL.WCE Refactor file writing - information on our use of Perl and Perl modules 2016-01-22 23:12:22 +01:00
INSTALL.WIN Refactor file writing - information on our use of Perl and Perl modules 2016-01-22 23:12:22 +01:00
LICENSE Update license year range to 2016 2016-01-19 10:24:05 -05:00
Makefile.in Enhance and clear the support of linker flags 2016-02-06 17:57:19 +01:00
Makefile.shared Display the linking commands that are performed 2016-02-06 17:57:19 +01:00
makevms.com Remove EIGHT_BIT and SIXTEEN_BIT 2016-01-27 19:10:13 -05:00
NEWS Refactoring BIO: Add a few lines in CHANGES & NEWS 2016-02-03 20:38:48 +01:00
openssl.doxy
openssl.spec
PROBLEMS Fixing typo in PROBLEMS 2015-09-27 20:50:40 -04:00
README Fix typos 2016-01-27 12:08:11 -05:00
README.ECC
README.ENGINE
README.FIPS Remove more (rest?) of FIPS build stuff. 2016-01-06 12:07:26 -05:00
README.PERL Refactor file writing - information on our use of Perl and Perl modules 2016-01-22 23:12:22 +01:00

 OpenSSL 1.1.0-pre3-dev

 Copyright (c) 1998-2016 The OpenSSL Project
 Copyright (c) 1995-1998 Eric A. Young, Tim J. Hudson
 All rights reserved.

 DESCRIPTION
 -----------

 The OpenSSL Project is a collaborative effort to develop a robust,
 commercial-grade, fully featured, and Open Source toolkit implementing the
 Secure Sockets Layer (SSLv3) and Transport Layer Security (TLS) protocols as
 well as a full-strength general purpose cryptographic library. The project is
 managed by a worldwide community of volunteers that use the Internet to
 communicate, plan, and develop the OpenSSL toolkit and its related
 documentation.

 OpenSSL is descended from the SSLeay library developed by Eric A. Young
 and Tim J. Hudson.  The OpenSSL toolkit is licensed under a dual-license (the
 OpenSSL license plus the SSLeay license), which means that you are free to
 get and use it for commercial and non-commercial purposes as long as you
 fulfill the conditions of both licenses.

 OVERVIEW
 --------

 The OpenSSL toolkit includes:

 libssl.a:
     Provides the client and server-side implementations for SSLv3 and TLS.

 libcrypto.a:
     Provides general cryptographic and X.509 support needed by SSL/TLS but
     not logically part of it.

 openssl:
     A command line tool that can be used for:
        Creation of key parameters
        Creation of X.509 certificates, CSRs and CRLs
        Calculation of message digests
        Encryption and decryption
        SSL/TLS client and server tests
        Handling of S/MIME signed or encrypted mail
        And more...

 INSTALLATION
 ------------

 See the appropriate file:
        INSTALL         Linux, Unix, etc.
        INSTALL.DJGPP   DOS platform with DJGPP
        INSTALL.NW      Netware
        INSTALL.OS2     OS/2
        INSTALL.VMS     VMS
        INSTALL.WIN     Windows
        INSTALL.WCE     Windows CE

 SUPPORT
 -------

 See the OpenSSL website www.openssl.org for details on how to obtain
 commercial technical support.

 If you have any problems with OpenSSL then please take the following steps
 first:

    - Download the current snapshot from ftp://ftp.openssl.org/snapshot/
      to see if the problem has already been addressed
    - Remove ASM versions of libraries
    - Remove compiler optimisation flags

 If you wish to report a bug then please include the following information in
 any bug report:

    - On Unix systems:
        Self-test report generated by 'make report'
    - On other systems:
        OpenSSL version: output of 'openssl version -a'
        OS Name, Version, Hardware platform
        Compiler Details (name, version)
    - Application Details (name, version)
    - Problem Description (steps that will reproduce the problem, if known)
    - Stack Traceback (if the application dumps core)

 Email the report to:

    rt@openssl.org

 In order to avoid spam, this is a moderated mailing list, and it might
 take a day for the ticket to show up.  (We also scan posts to make sure
 that security disclosures aren't publically posted by mistake.) Mail
 to this address is recorded in the public RT (request tracker) database
 (see https://www.openssl.org/community/index.html#bugs for details) and
 also forwarded the public openssl-dev mailing list.  Confidential mail
 may be sent to openssl-security@openssl.org (PGP key available from the
 key servers).

 Please do NOT use this for general assistance or support queries.
 Just because something doesn't work the way you expect does not mean it
 is necessarily a bug in OpenSSL.

 You can also make GitHub pull requests. If you do this, please also send
 mail to rt@openssl.org with a link to the PR so that we can more easily
 keep track of it.

 HOW TO CONTRIBUTE TO OpenSSL
 ----------------------------

 See CONTRIBUTING

 LEGALITIES
 ----------

 A number of nations, in particular the U.S., restrict the use or export
 of cryptography. If you are potentially subject to such restrictions
 you should seek competent professional legal advice before attempting to
 develop or distribute cryptographic code.