mirror of
https://github.com/openssl/openssl.git
synced 2024-11-27 05:21:51 +08:00
b33c48b75a
If a GENERAL_NAME field contained EdiPartyName data then it was incorrectly being handled as type "other". This could lead to a segmentation fault. Many thanks to David Benjamin from Google for reporting this issue. CVE-2020-1971 Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
242 lines
6.3 KiB
C
242 lines
6.3 KiB
C
/*
|
|
* Copyright 1999-2016 The OpenSSL Project Authors. All Rights Reserved.
|
|
*
|
|
* Licensed under the Apache License 2.0 (the "License"). You may not use
|
|
* this file except in compliance with the License. You can obtain a copy
|
|
* in the file LICENSE in the source distribution or at
|
|
* https://www.openssl.org/source/license.html
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include "internal/cryptlib.h"
|
|
#include <openssl/asn1t.h>
|
|
#include <openssl/conf.h>
|
|
#include <openssl/x509v3.h>
|
|
|
|
ASN1_SEQUENCE(OTHERNAME) = {
|
|
ASN1_SIMPLE(OTHERNAME, type_id, ASN1_OBJECT),
|
|
/* Maybe have a true ANY DEFINED BY later */
|
|
ASN1_EXP(OTHERNAME, value, ASN1_ANY, 0)
|
|
} ASN1_SEQUENCE_END(OTHERNAME)
|
|
|
|
IMPLEMENT_ASN1_FUNCTIONS(OTHERNAME)
|
|
|
|
ASN1_SEQUENCE(EDIPARTYNAME) = {
|
|
/* DirectoryString is a CHOICE type so use explicit tagging */
|
|
ASN1_EXP_OPT(EDIPARTYNAME, nameAssigner, DIRECTORYSTRING, 0),
|
|
ASN1_EXP(EDIPARTYNAME, partyName, DIRECTORYSTRING, 1)
|
|
} ASN1_SEQUENCE_END(EDIPARTYNAME)
|
|
|
|
IMPLEMENT_ASN1_FUNCTIONS(EDIPARTYNAME)
|
|
|
|
ASN1_CHOICE(GENERAL_NAME) = {
|
|
ASN1_IMP(GENERAL_NAME, d.otherName, OTHERNAME, GEN_OTHERNAME),
|
|
ASN1_IMP(GENERAL_NAME, d.rfc822Name, ASN1_IA5STRING, GEN_EMAIL),
|
|
ASN1_IMP(GENERAL_NAME, d.dNSName, ASN1_IA5STRING, GEN_DNS),
|
|
/* Don't decode this */
|
|
ASN1_IMP(GENERAL_NAME, d.x400Address, ASN1_SEQUENCE, GEN_X400),
|
|
/* X509_NAME is a CHOICE type so use EXPLICIT */
|
|
ASN1_EXP(GENERAL_NAME, d.directoryName, X509_NAME, GEN_DIRNAME),
|
|
ASN1_IMP(GENERAL_NAME, d.ediPartyName, EDIPARTYNAME, GEN_EDIPARTY),
|
|
ASN1_IMP(GENERAL_NAME, d.uniformResourceIdentifier, ASN1_IA5STRING, GEN_URI),
|
|
ASN1_IMP(GENERAL_NAME, d.iPAddress, ASN1_OCTET_STRING, GEN_IPADD),
|
|
ASN1_IMP(GENERAL_NAME, d.registeredID, ASN1_OBJECT, GEN_RID)
|
|
} ASN1_CHOICE_END(GENERAL_NAME)
|
|
|
|
IMPLEMENT_ASN1_FUNCTIONS(GENERAL_NAME)
|
|
|
|
ASN1_ITEM_TEMPLATE(GENERAL_NAMES) =
|
|
ASN1_EX_TEMPLATE_TYPE(ASN1_TFLG_SEQUENCE_OF, 0, GeneralNames, GENERAL_NAME)
|
|
ASN1_ITEM_TEMPLATE_END(GENERAL_NAMES)
|
|
|
|
IMPLEMENT_ASN1_FUNCTIONS(GENERAL_NAMES)
|
|
|
|
GENERAL_NAME *GENERAL_NAME_dup(const GENERAL_NAME *a)
|
|
{
|
|
return (GENERAL_NAME *)ASN1_dup((i2d_of_void *)i2d_GENERAL_NAME,
|
|
(d2i_of_void *)d2i_GENERAL_NAME,
|
|
(char *)a);
|
|
}
|
|
|
|
static int edipartyname_cmp(const EDIPARTYNAME *a, const EDIPARTYNAME *b)
|
|
{
|
|
int res;
|
|
|
|
if (a == NULL || b == NULL) {
|
|
/*
|
|
* Shouldn't be possible in a valid GENERAL_NAME, but we handle it
|
|
* anyway. OTHERNAME_cmp treats NULL != NULL so we do the same here
|
|
*/
|
|
return -1;
|
|
}
|
|
if (a->nameAssigner == NULL && b->nameAssigner != NULL)
|
|
return -1;
|
|
if (a->nameAssigner != NULL && b->nameAssigner == NULL)
|
|
return 1;
|
|
/* If we get here then both have nameAssigner set, or both unset */
|
|
if (a->nameAssigner != NULL) {
|
|
res = ASN1_STRING_cmp(a->nameAssigner, b->nameAssigner);
|
|
if (res != 0)
|
|
return res;
|
|
}
|
|
/*
|
|
* partyName is required, so these should never be NULL. We treat it in
|
|
* the same way as the a == NULL || b == NULL case above
|
|
*/
|
|
if (a->partyName == NULL || b->partyName == NULL)
|
|
return -1;
|
|
|
|
return ASN1_STRING_cmp(a->partyName, b->partyName);
|
|
}
|
|
|
|
/* Returns 0 if they are equal, != 0 otherwise. */
|
|
int GENERAL_NAME_cmp(GENERAL_NAME *a, GENERAL_NAME *b)
|
|
{
|
|
int result = -1;
|
|
|
|
if (!a || !b || a->type != b->type)
|
|
return -1;
|
|
switch (a->type) {
|
|
case GEN_X400:
|
|
result = ASN1_TYPE_cmp(a->d.x400Address, b->d.x400Address);
|
|
break;
|
|
|
|
case GEN_EDIPARTY:
|
|
result = edipartyname_cmp(a->d.ediPartyName, b->d.ediPartyName);
|
|
break;
|
|
|
|
case GEN_OTHERNAME:
|
|
result = OTHERNAME_cmp(a->d.otherName, b->d.otherName);
|
|
break;
|
|
|
|
case GEN_EMAIL:
|
|
case GEN_DNS:
|
|
case GEN_URI:
|
|
result = ASN1_STRING_cmp(a->d.ia5, b->d.ia5);
|
|
break;
|
|
|
|
case GEN_DIRNAME:
|
|
result = X509_NAME_cmp(a->d.dirn, b->d.dirn);
|
|
break;
|
|
|
|
case GEN_IPADD:
|
|
result = ASN1_OCTET_STRING_cmp(a->d.ip, b->d.ip);
|
|
break;
|
|
|
|
case GEN_RID:
|
|
result = OBJ_cmp(a->d.rid, b->d.rid);
|
|
break;
|
|
}
|
|
return result;
|
|
}
|
|
|
|
/* Returns 0 if they are equal, != 0 otherwise. */
|
|
int OTHERNAME_cmp(OTHERNAME *a, OTHERNAME *b)
|
|
{
|
|
int result = -1;
|
|
|
|
if (!a || !b)
|
|
return -1;
|
|
/* Check their type first. */
|
|
if ((result = OBJ_cmp(a->type_id, b->type_id)) != 0)
|
|
return result;
|
|
/* Check the value. */
|
|
result = ASN1_TYPE_cmp(a->value, b->value);
|
|
return result;
|
|
}
|
|
|
|
void GENERAL_NAME_set0_value(GENERAL_NAME *a, int type, void *value)
|
|
{
|
|
switch (type) {
|
|
case GEN_X400:
|
|
a->d.x400Address = value;
|
|
break;
|
|
|
|
case GEN_EDIPARTY:
|
|
a->d.ediPartyName = value;
|
|
break;
|
|
|
|
case GEN_OTHERNAME:
|
|
a->d.otherName = value;
|
|
break;
|
|
|
|
case GEN_EMAIL:
|
|
case GEN_DNS:
|
|
case GEN_URI:
|
|
a->d.ia5 = value;
|
|
break;
|
|
|
|
case GEN_DIRNAME:
|
|
a->d.dirn = value;
|
|
break;
|
|
|
|
case GEN_IPADD:
|
|
a->d.ip = value;
|
|
break;
|
|
|
|
case GEN_RID:
|
|
a->d.rid = value;
|
|
break;
|
|
}
|
|
a->type = type;
|
|
}
|
|
|
|
void *GENERAL_NAME_get0_value(const GENERAL_NAME *a, int *ptype)
|
|
{
|
|
if (ptype)
|
|
*ptype = a->type;
|
|
switch (a->type) {
|
|
case GEN_X400:
|
|
return a->d.x400Address;
|
|
|
|
case GEN_EDIPARTY:
|
|
return a->d.ediPartyName;
|
|
|
|
case GEN_OTHERNAME:
|
|
return a->d.otherName;
|
|
|
|
case GEN_EMAIL:
|
|
case GEN_DNS:
|
|
case GEN_URI:
|
|
return a->d.ia5;
|
|
|
|
case GEN_DIRNAME:
|
|
return a->d.dirn;
|
|
|
|
case GEN_IPADD:
|
|
return a->d.ip;
|
|
|
|
case GEN_RID:
|
|
return a->d.rid;
|
|
|
|
default:
|
|
return NULL;
|
|
}
|
|
}
|
|
|
|
int GENERAL_NAME_set0_othername(GENERAL_NAME *gen,
|
|
ASN1_OBJECT *oid, ASN1_TYPE *value)
|
|
{
|
|
OTHERNAME *oth;
|
|
oth = OTHERNAME_new();
|
|
if (oth == NULL)
|
|
return 0;
|
|
ASN1_TYPE_free(oth->value);
|
|
oth->type_id = oid;
|
|
oth->value = value;
|
|
GENERAL_NAME_set0_value(gen, GEN_OTHERNAME, oth);
|
|
return 1;
|
|
}
|
|
|
|
int GENERAL_NAME_get0_otherName(const GENERAL_NAME *gen,
|
|
ASN1_OBJECT **poid, ASN1_TYPE **pvalue)
|
|
{
|
|
if (gen->type != GEN_OTHERNAME)
|
|
return 0;
|
|
if (poid)
|
|
*poid = gen->d.otherName->type_id;
|
|
if (pvalue)
|
|
*pvalue = gen->d.otherName->value;
|
|
return 1;
|
|
}
|