openssl/crypto/asn1
Matt Caswell 9e488fd6ab ASN1_primitive_new NULL param handling
ASN1_primitive_new takes an ASN1_ITEM * param |it|. There are a couple
of conditional code paths that check whether |it| is NULL or not - but
later |it| is deref'd unconditionally. If |it| was ever really NULL then
this would seg fault. In practice ASN1_primitive_new is marked as an
internal function in the public header file. The only places it is ever
used internally always pass a non NULL parameter for |it|. Therefore, change
the code to sanity check that |it| is not NULL, and remove the conditional
checking.

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Andy Polyakov <appro@openssl.org>
2015-03-12 09:20:45 +00:00
..
a_bitstr.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_bool.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_bytes.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_d2i_fp.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_digest.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_dup.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_enum.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_gentm.c Dead code removal: #if 0 asn1, pkcs7 2015-01-30 15:35:49 -05:00
a_i2d_fp.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_int.c Remove obsolete IMPLEMENT_ASN1_SET_OF 2015-02-09 12:47:28 +00:00
a_mbstr.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_object.c Remove obsolete IMPLEMENT_ASN1_SET_OF 2015-02-09 12:47:28 +00:00
a_octet.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_print.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_set.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_sign.c Re-align some comments after running the reformat script. 2015-01-22 09:20:10 +00:00
a_strex.c Dead code removal: #if 0 asn1, pkcs7 2015-01-30 15:35:49 -05:00
a_strnid.c util/mkstack.pl now generates entire safestack.h 2015-02-06 10:47:53 -05:00
a_time.c Dead code removal: #if 0 asn1, pkcs7 2015-01-30 15:35:49 -05:00
a_type.c Remove obsolete IMPLEMENT_ASN1_SET_OF 2015-02-09 12:47:28 +00:00
a_utctm.c Dead code removal: #if 0 asn1, pkcs7 2015-01-30 15:35:49 -05:00
a_utf8.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
a_verify.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
ameth_lib.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
asn1_err.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
asn1_gen.c Fix seg fault in ASN1_generate_v3/ASN1_generate_nconf 2015-03-11 11:18:15 +00:00
asn1_lib.c Cleanse PKCS#8 private key components. 2015-03-08 16:27:55 +00:00
asn1_locl.h Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
asn1_mac.h Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
asn1_par.c Fix wrong numbers being passed as string lengths 2015-03-09 21:02:41 +01:00
asn1.h Cleanse PKCS#8 private key components. 2015-03-08 16:27:55 +00:00
asn1t.h Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
asn_mime.c util/mkstack.pl now generates entire safestack.h 2015-02-06 10:47:53 -05:00
asn_moid.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
asn_mstbl.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
asn_pack.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
bio_asn1.c clang on Linux x86_64 complains about unreachable code. 2015-01-29 01:54:09 +01:00
bio_ndef.c Unchecked malloc fixes 2015-03-05 09:09:57 +00:00
charmap.h Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
charmap.pl RT1815: More const'ness improvements 2014-08-18 11:49:16 -04:00
d2i_pr.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
d2i_pu.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
evp_asn1.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
f_enum.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
f_int.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
f_string.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
i2d_pr.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
i2d_pu.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
Makefile Implement internally opaque bn access from asn1 2014-12-08 21:40:26 +00:00
n_pkey.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
nsseq.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
p5_pbe.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
p5_pbev2.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
p8_pkey.c Check PKCS#8 pkey field is valid before cleansing. 2015-02-03 13:58:14 +00:00
t_bitst.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
t_crl.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
t_pkey.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
t_req.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
t_spki.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
t_x509.c Dead code removal: #if 0 asn1, pkcs7 2015-01-30 15:35:49 -05:00
t_x509a.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
tasn_dec.c clang on Linux x86_64 complains about unreachable code. 2015-01-29 01:54:09 +01:00
tasn_enc.c clang on Linux x86_64 complains about unreachable code. 2015-01-29 01:54:09 +01:00
tasn_fre.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
tasn_new.c ASN1_primitive_new NULL param handling 2015-03-12 09:20:45 +00:00
tasn_prn.c Dead code removal: #if 0 asn1, pkcs7 2015-01-30 15:35:49 -05:00
tasn_scn.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
tasn_typ.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
tasn_utl.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x_algor.c Remove obsolete IMPLEMENT_ASN1_SET_OF 2015-02-09 12:47:28 +00:00
x_attrib.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x_bignum.c Fix format script. 2015-03-02 13:26:29 +00:00
x_crl.c Remove obsolete IMPLEMENT_ASN1_SET_OF 2015-02-09 12:47:28 +00:00
x_exten.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x_info.c util/mkstack.pl now generates entire safestack.h 2015-02-06 10:47:53 -05:00
x_long.c Fix format script. 2015-03-02 13:26:29 +00:00
x_name.c Remove obsolete IMPLEMENT_ASN1_SET_OF 2015-02-09 12:47:28 +00:00
x_nx509.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x_pkey.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x_pubkey.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x_req.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x_sig.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x_spki.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x_val.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x_x509.c OPENSSL_NO_xxx cleanup: RFC3779 2015-01-27 10:19:14 -05:00
x_x509a.c Remove X509_PAIR 2015-02-06 10:55:31 -05:00