openssl/test
Dr. Matthias St. Pierre 3064b55134 DRBG: fix reseeding via RAND_add()/RAND_seed() with large input
In pull request #4328 the seeding of the DRBG via RAND_add()/RAND_seed()
was implemented by buffering the data in a random pool where it is
picked up later by the rand_drbg_get_entropy() callback. This buffer
was limited to the size of 4096 bytes.

When a larger input was added via RAND_add() or RAND_seed() to the DRBG,
the reseeding failed, but the error returned by the DRBG was ignored
by the two calling functions, which both don't return an error code.
As a consequence, the data provided by the application was effectively
ignored.

This commit fixes the problem by a more efficient implementation which
does not copy the data in memory and by raising the buffer the size limit
to INT32_MAX (2 gigabytes). This is less than the NIST limit of 2^35 bits
but it was chosen intentionally to avoid platform dependent problems
like integer sizes and/or signed/unsigned conversion.

Additionally, the DRBG is now less permissive on errors: In addition to
pushing a message to the openssl error stack, it enters the error state,
which forces a reinstantiation on next call.

Thanks go to Dr. Falko Strenzke for reporting this issue to the
openssl-security mailing list. After internal discussion the issue
has been categorized as not being security relevant, because the DRBG
reseeds automatically and is fully functional even without additional
randomness provided by the application.

Fixes #7381

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/7382)
2018-10-16 22:15:43 +02:00
..
certs
ct
d2i-tests
ocsp-tests
ossl_shim
recipes Refactor util/mkdef.pl for clearer separation of functionality 2018-10-03 22:16:10 +02:00
smime-certs
ssl-tests Add a test for RSA key exchange with both RSA and RSA-PSS certs 2018-09-04 11:28:01 +01:00
testutil Update copyright year 2018-09-11 13:45:17 +01:00
aborttest.c
afalgtest.c
asn1_decode_test.c TESTS: add test of decoding of invalid zero length ASN.1 INTEGER zero 2018-09-09 03:35:26 +02:00
asn1_encode_test.c
asn1_internal_test.c Update copyright year 2018-09-11 13:45:17 +01:00
asn1_string_table_test.c
asn1_time_test.c
asynciotest.c
asynctest.c
bad_dtls_test.c
bftest.c
bio_callback_test.c Extend the BIO callback tests to check the return value semantics 2018-10-04 14:16:16 +01:00
bio_enc_test.c
bioprinttest.c
bntest.c
bntests.pl
build.info Added DRBG_HMAC & DRBG_HASH + Added defaults for setting DRBG for master/public/private + renamed generate_counter back to reseed_counter + generated new cavs data tests 2018-09-28 07:22:13 +10:00
CAss.cnf
CAssdh.cnf
CAssdsa.cnf
CAssrsa.cnf
casttest.c
CAtsa.cnf
chacha_internal_test.c
cipher_overhead_test.c VMS: turn on name mangling for all our programs 2018-09-14 11:00:38 +02:00
cipherbytes_test.c
cipherlist_test.c
ciphername_test.c
clienthellotest.c
cms-examples.pl
cmsapitest.c
conf_include_test.c
constant_time_test.c
crltest.c
ct_test.c Add an explicit cast to time_t 2018-09-13 09:00:29 +01:00
ctype_internal_test.c
curve448_internal_test.c VMS: turn on name mangling for all our programs 2018-09-14 11:00:38 +02:00
d2i_test.c
danetest.c
danetest.in
danetest.pem
destest.c
dhtest.c test/dhtest.c: fix resource leak 2018-09-10 10:32:33 +01:00
drbg_cavs_data_ctr.c Added DRBG_HMAC & DRBG_HASH + Added defaults for setting DRBG for master/public/private + renamed generate_counter back to reseed_counter + generated new cavs data tests 2018-09-28 07:22:13 +10:00
drbg_cavs_data_hash.c Added DRBG_HMAC & DRBG_HASH + Added defaults for setting DRBG for master/public/private + renamed generate_counter back to reseed_counter + generated new cavs data tests 2018-09-28 07:22:13 +10:00
drbg_cavs_data_hmac.c Added DRBG_HMAC & DRBG_HASH + Added defaults for setting DRBG for master/public/private + renamed generate_counter back to reseed_counter + generated new cavs data tests 2018-09-28 07:22:13 +10:00
drbg_cavs_data.h Added DRBG_HMAC & DRBG_HASH + Added defaults for setting DRBG for master/public/private + renamed generate_counter back to reseed_counter + generated new cavs data tests 2018-09-28 07:22:13 +10:00
drbg_cavs_test.c Added DRBG_HMAC & DRBG_HASH + Added defaults for setting DRBG for master/public/private + renamed generate_counter back to reseed_counter + generated new cavs data tests 2018-09-28 07:22:13 +10:00
drbgtest.c DRBG: fix reseeding via RAND_add()/RAND_seed() with large input 2018-10-16 22:15:43 +02:00
drbgtest.h Added DRBG_HMAC & DRBG_HASH + Added defaults for setting DRBG for master/public/private + renamed generate_counter back to reseed_counter + generated new cavs data tests 2018-09-28 07:22:13 +10:00
dsa_no_digest_size_test.c
dsatest.c
dtls_mtu_test.c
dtlstest.c
dtlsv1listentest.c
ecdsatest.c Fix no-engine 2018-10-10 09:40:01 +01:00
ecstresstest.c Update copyright year 2018-09-11 13:45:17 +01:00
ectest.c
enginetest.c
errtest.c
evp_extra_test.c test/evp_extra_test.c: fix null pointer dereference 2018-09-10 11:11:43 +01:00
evp_test.c Trivial test improvements 2018-09-18 09:22:10 +02:00
evp_test.h
exdatatest.c
exptest.c
fatalerrtest.c
generate_buildtest.pl
generate_ssl_tests.pl
gmdifftest.c
gosttest.c
handshake_helper.c
handshake_helper.h
hmactest.c
ideatest.c
igetest.c
lhash_test.c
md2test.c
mdc2_internal_test.c
mdc2test.c
memleaktest.c
modes_internal_test.c
ocspapitest.c
P1ss.cnf
P2ss.cnf
packettest.c
pbelutest.c
pemtest.c Update copyright year 2018-09-11 13:45:17 +01:00
pkcs7-1.pem
pkcs7.pem
pkey_meth_kdf_test.c
pkey_meth_test.c
pkits-test.pl
poly1305_internal_test.c
rc2test.c
rc4test.c
rc5test.c
rdrand_sanitytest.c
README
README.external
README.ssltest.md
recordlentest.c
rsa_complex.c Add a compile time test to verify that openssl/rsa.h and complex.h can 2018-09-17 09:14:03 +10:00
rsa_mp_test.c
rsa_test.c
run_tests.pl
sanitytest.c Update copyright year 2018-09-11 13:45:17 +01:00
secmemtest.c test/secmemtest: test secure memory only if it is implemented 2018-10-05 12:19:48 +02:00
serverinfo2.pem
serverinfo.pem
servername_test.c Update copyright year 2018-09-11 13:45:17 +01:00
session.pem
shibboleth.pfx
shlibloadtest.c
siphash_internal_test.c SipHash: add separate setter for the hash size 2018-09-09 01:47:56 +02:00
sm2_internal_test.c Make SM2 ID stick to specification 2018-09-07 18:12:26 +08:00
sm4_internal_test.c
smcont.txt
srptest.c
ssl_cert_table_internal_test.c VMS: turn on name mangling for all our programs 2018-09-14 11:00:38 +02:00
ssl_test_ctx_test.c
ssl_test_ctx_test.conf
ssl_test_ctx.c
ssl_test_ctx.h
ssl_test.c
ssl_test.tmpl
sslapitest.c Fix no-tls1_2 2018-09-25 16:08:28 +01:00
sslbuffertest.c
sslcorrupttest.c
ssltest_old.c
ssltestlib.c Add a test for the certificate callback 2018-09-21 17:39:14 +01:00
ssltestlib.h
Sssdsa.cnf
Sssrsa.cnf
stack_test.c
sysdefault.cnf
sysdefaulttest.c
test_test.c
test.cnf
testcrl.pem
testdsa.pem
testdsapub.pem
testec-p256.pem
testecpub-p256.pem
testp7.pem
testreq2.pem
testrsa.pem
testrsapub.pem
testsid.pem
testutil.h
testx509.pem
threadstest.c
time_offset_test.c
tls13ccstest.c
tls13encryptiontest.c VMS: turn on name mangling for all our programs 2018-09-14 11:00:38 +02:00
tls13secretstest.c VMS: turn on name mangling for all our programs 2018-09-14 11:00:38 +02:00
uitest.c
Uss.cnf
v3-cert1.pem
v3-cert2.pem
v3ext.c
v3nametest.c
verify_extra_test.c
versions.c
wpackettest.c VMS: turn on name mangling for all our programs 2018-09-14 11:00:38 +02:00
x509_check_cert_pkey_test.c
x509_dup_cert_test.c
x509_internal_test.c VMS: turn on name mangling for all our programs 2018-09-14 11:00:38 +02:00
x509_time_test.c
x509aux.c

How to add recipes
==================

For any test that you want to perform, you write a script located in
test/recipes/, named {nn}-test_{name}.t, where {nn} is a two digit number and
{name} is a unique name of your choice.

Please note that if a test involves a new testing executable, you will need to
do some additions in test/Makefile.  More on this later.


Naming conventions
=================

A test executable is named test/{name}test.c

A test recipe is named test/recipes/{nn}-test_{name}.t, where {nn} is a two
digit number and {name} is a unique name of your choice.

The number {nn} is (somewhat loosely) grouped as follows:

00-04  sanity, internal and essential API tests
05-09  individual symmetric cipher algorithms
10-14  math (bignum)
15-19  individual asymmetric cipher algorithms
20-24  openssl commands (some otherwise not tested)
25-29  certificate forms, generation and verification
30-35  engine and evp
60-79  APIs
   70  PACKET layer
80-89  "larger" protocols (CA, CMS, OCSP, SSL, TSA)
90-98  misc
99     most time consuming tests [such as test_fuzz]


A recipe that just runs a test executable
=========================================

A script that just runs a program looks like this:

    #! /usr/bin/perl

    use OpenSSL::Test::Simple;

    simple_test("test_{name}", "{name}test", "{name}");

{name} is the unique name you have chosen for your test.

The second argument to `simple_test' is the test executable, and `simple_test'
expects it to be located in test/

For documentation on OpenSSL::Test::Simple, do
`perldoc util/perl/OpenSSL/Test/Simple.pm'.


A recipe that runs a more complex test
======================================

For more complex tests, you will need to read up on Test::More and
OpenSSL::Test.  Test::More is normally preinstalled, do `man Test::More' for
documentation.  For OpenSSL::Test, do `perldoc util/perl/OpenSSL/Test.pm'.

A script to start from could be this:

    #! /usr/bin/perl

    use strict;
    use warnings;
    use OpenSSL::Test;

    setup("test_{name}");

    plan tests => 2;                # The number of tests being performed

    ok(test1, "test1");
    ok(test2, "test1");

    sub test1
    {
        # test feature 1
    }

    sub test2
    {
        # test feature 2
    }


Changes to test/build.info
==========================

Whenever a new test involves a new test executable you need to do the
following (at all times, replace {NAME} and {name} with the name of your
test):

* add {name} to the list of programs under PROGRAMS_NO_INST

* create a three line description of how to build the test, you will have
to modify the include paths and source files if you don't want to use the
basic test framework:

    SOURCE[{name}]={name}.c
    INCLUDE[{name}]=.. ../include
    DEPEND[{name}]=../libcrypto libtestutil.a

Generic form of C test executables
==================================

    #include "testutil.h"

    static int my_test(void)
    {
        int testresult = 0;                 /* Assume the test will fail    */
        int observed;

        observed = function();              /* Call the code under test     */
        if (!TEST_int_equal(observed, 2))   /* Check the result is correct  */
            goto end;                       /* Exit on failure - optional   */

        testresult = 1;                     /* Mark the test case a success */
    end:
        cleanup();                          /* Any cleanup you require      */
        return testresult;
    }

    int setup_tests(void)
    {
        ADD_TEST(my_test);                  /* Add each test separately     */
        return 1;                           /* Indicate success             */
    }

You should use the TEST_xxx macros provided by testutil.h to test all failure
conditions.  These macros produce an error message in a standard format if the
condition is not met (and nothing if the condition is met).  Additional
information can be presented with the TEST_info macro that takes a printf
format string and arguments.  TEST_error is useful for complicated conditions,
it also takes a printf format string and argument.  In all cases the TEST_xxx
macros are guaranteed to evaluate their arguments exactly once.  This means
that expressions with side effects are allowed as parameters.  Thus,

    if (!TEST_ptr(ptr = OPENSSL_malloc(..)))

works fine and can be used in place of:

    ptr = OPENSSL_malloc(..);
    if (!TEST_ptr(ptr))

The former produces a more meaningful message on failure than the latter.