mirror of
https://github.com/openssl/openssl.git
synced 2024-12-27 06:21:43 +08:00
e077455e9e
Since OPENSSL_malloc() and friends report ERR_R_MALLOC_FAILURE, and at least handle the file name and line number they are called from, there's no need to report ERR_R_MALLOC_FAILURE where they are called directly, or when SSLfatal() and RLAYERfatal() is used, the reason `ERR_R_MALLOC_FAILURE` is changed to `ERR_R_CRYPTO_LIB`. There were a number of places where `ERR_R_MALLOC_FAILURE` was reported even though it was a function from a different sub-system that was called. Those places are changed to report ERR_R_{lib}_LIB, where {lib} is the name of that sub-system. Some of them are tricky to get right, as we have a lot of functions that belong in the ASN1 sub-system, and all the `sk_` calls or from the CRYPTO sub-system. Some extra adaptation was necessary where there were custom OPENSSL_malloc() wrappers, and some bugs are fixed alongside these changes. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from https://github.com/openssl/openssl/pull/19301)
141 lines
4.4 KiB
C
141 lines
4.4 KiB
C
/*
|
|
* Copyright 2015-2022 The OpenSSL Project Authors. All Rights Reserved.
|
|
*
|
|
* Licensed under the Apache License 2.0 (the "License"). You may not use
|
|
* this file except in compliance with the License. You can obtain a copy
|
|
* in the file LICENSE in the source distribution or at
|
|
* https://www.openssl.org/source/license.html
|
|
*/
|
|
|
|
#include "internal/e_os.h"
|
|
#include "internal/cryptlib.h"
|
|
#include <stdio.h>
|
|
#include <openssl/asn1t.h>
|
|
#include <openssl/conf.h>
|
|
#include <openssl/x509v3.h>
|
|
#include "ext_dat.h"
|
|
#include "x509_local.h"
|
|
|
|
static STACK_OF(CONF_VALUE) *i2v_TLS_FEATURE(const X509V3_EXT_METHOD *method,
|
|
TLS_FEATURE *tls_feature,
|
|
STACK_OF(CONF_VALUE) *ext_list);
|
|
static TLS_FEATURE *v2i_TLS_FEATURE(const X509V3_EXT_METHOD *method,
|
|
X509V3_CTX *ctx,
|
|
STACK_OF(CONF_VALUE) *nval);
|
|
|
|
ASN1_ITEM_TEMPLATE(TLS_FEATURE) =
|
|
ASN1_EX_TEMPLATE_TYPE(ASN1_TFLG_SEQUENCE_OF, 0, TLS_FEATURE, ASN1_INTEGER)
|
|
static_ASN1_ITEM_TEMPLATE_END(TLS_FEATURE)
|
|
|
|
IMPLEMENT_ASN1_ALLOC_FUNCTIONS(TLS_FEATURE)
|
|
|
|
const X509V3_EXT_METHOD ossl_v3_tls_feature = {
|
|
NID_tlsfeature, 0,
|
|
ASN1_ITEM_ref(TLS_FEATURE),
|
|
0, 0, 0, 0,
|
|
0, 0,
|
|
(X509V3_EXT_I2V)i2v_TLS_FEATURE,
|
|
(X509V3_EXT_V2I)v2i_TLS_FEATURE,
|
|
0, 0,
|
|
NULL
|
|
};
|
|
|
|
|
|
typedef struct {
|
|
long num;
|
|
const char *name;
|
|
} TLS_FEATURE_NAME;
|
|
|
|
static TLS_FEATURE_NAME tls_feature_tbl[] = {
|
|
{ 5, "status_request" },
|
|
{ 17, "status_request_v2" }
|
|
};
|
|
|
|
/*
|
|
* i2v_TLS_FEATURE converts the TLS_FEATURE structure tls_feature into the
|
|
* STACK_OF(CONF_VALUE) structure ext_list. STACK_OF(CONF_VALUE) is the format
|
|
* used by the CONF library to represent a multi-valued extension. ext_list is
|
|
* returned.
|
|
*/
|
|
static STACK_OF(CONF_VALUE) *i2v_TLS_FEATURE(const X509V3_EXT_METHOD *method,
|
|
TLS_FEATURE *tls_feature,
|
|
STACK_OF(CONF_VALUE) *ext_list)
|
|
{
|
|
int i;
|
|
size_t j;
|
|
ASN1_INTEGER *ai;
|
|
long tlsextid;
|
|
for (i = 0; i < sk_ASN1_INTEGER_num(tls_feature); i++) {
|
|
ai = sk_ASN1_INTEGER_value(tls_feature, i);
|
|
tlsextid = ASN1_INTEGER_get(ai);
|
|
for (j = 0; j < OSSL_NELEM(tls_feature_tbl); j++)
|
|
if (tlsextid == tls_feature_tbl[j].num)
|
|
break;
|
|
if (j < OSSL_NELEM(tls_feature_tbl))
|
|
X509V3_add_value(NULL, tls_feature_tbl[j].name, &ext_list);
|
|
else
|
|
X509V3_add_value_int(NULL, ai, &ext_list);
|
|
}
|
|
return ext_list;
|
|
}
|
|
|
|
/*
|
|
* v2i_TLS_FEATURE converts the multi-valued extension nval into a TLS_FEATURE
|
|
* structure, which is returned if the conversion is successful. In case of
|
|
* error, NULL is returned.
|
|
*/
|
|
static TLS_FEATURE *v2i_TLS_FEATURE(const X509V3_EXT_METHOD *method,
|
|
X509V3_CTX *ctx, STACK_OF(CONF_VALUE) *nval)
|
|
{
|
|
TLS_FEATURE *tlsf;
|
|
char *extval, *endptr;
|
|
ASN1_INTEGER *ai = NULL;
|
|
CONF_VALUE *val;
|
|
int i;
|
|
size_t j;
|
|
long tlsextid;
|
|
|
|
if ((tlsf = sk_ASN1_INTEGER_new_null()) == NULL) {
|
|
ERR_raise(ERR_LIB_X509V3, ERR_R_CRYPTO_LIB);
|
|
return NULL;
|
|
}
|
|
|
|
for (i = 0; i < sk_CONF_VALUE_num(nval); i++) {
|
|
val = sk_CONF_VALUE_value(nval, i);
|
|
if (val->value)
|
|
extval = val->value;
|
|
else
|
|
extval = val->name;
|
|
|
|
for (j = 0; j < OSSL_NELEM(tls_feature_tbl); j++)
|
|
if (OPENSSL_strcasecmp(extval, tls_feature_tbl[j].name) == 0)
|
|
break;
|
|
if (j < OSSL_NELEM(tls_feature_tbl))
|
|
tlsextid = tls_feature_tbl[j].num;
|
|
else {
|
|
tlsextid = strtol(extval, &endptr, 10);
|
|
if (((*endptr) != '\0') || (extval == endptr) || (tlsextid < 0) ||
|
|
(tlsextid > 65535)) {
|
|
ERR_raise(ERR_LIB_X509V3, X509V3_R_INVALID_SYNTAX);
|
|
X509V3_conf_add_error_name_value(val);
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
if ((ai = ASN1_INTEGER_new()) == NULL
|
|
|| !ASN1_INTEGER_set(ai, tlsextid)
|
|
|| sk_ASN1_INTEGER_push(tlsf, ai) <= 0) {
|
|
ERR_raise(ERR_LIB_X509V3, ERR_R_ASN1_LIB);
|
|
goto err;
|
|
}
|
|
/* So it doesn't get purged if an error occurs next time around */
|
|
ai = NULL;
|
|
}
|
|
return tlsf;
|
|
|
|
err:
|
|
sk_ASN1_INTEGER_pop_free(tlsf, ASN1_INTEGER_free);
|
|
ASN1_INTEGER_free(ai);
|
|
return NULL;
|
|
}
|