Go to file
Dr. Matthias St. Pierre 8cfc19716c rand_unix.c: open random devices on first use only
Commit c7504aeb64 (pr #6432) fixed a regression for applications in
chroot environments, which compensated the fact that the new OpenSSL CSPRNG
(based on the NIST DRBG) now reseeds periodically, which the previous
one didn't. Now the reseeding could fail in the chroot environment if the
DEVRANDOM devices were not present anymore and no other entropy source
(e.g. getrandom()) was available.

The solution was to keep the file handles for the DEVRANDOM devices open
by default. In fact, the fix did more than this, it opened the DEVRANDOM
devices early and unconditionally in rand_pool_init(), which had the
unwanted side effect that the devices were opened (and kept open) even
in cases when they were not used at all, for example when the getrandom()
system call was available. Due  to a bug (issue #7419) this even happened
when the feature was disabled by the application.

This commit removes the unconditional opening of all DEVRANDOM devices.
They will now only be opened (and kept open) on first use. In particular,
if getrandom() is available, the handles will not be opened unnecessarily.

This change does not introduce a regression for applications compiled for
libcrypto 1.1.0, because the SSLEAY RNG also seeds on first use. So in the
above constellation the CSPRNG will only be properly seeded if it is happens
before the forking and chrooting.

Fixes #7419

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/7437)
2018-11-08 16:38:26 +01:00
.github
apps apps: Stop pretending to care about Netscape keys 2018-11-02 10:58:35 +01:00
boringssl@2070f8ad91
Configurations Build: make it possibly to specify subdirs in build.info 2018-11-05 09:27:31 +01:00
crypto rand_unix.c: open random devices on first use only 2018-11-08 16:38:26 +01:00
demos Remove outdated e_chil.txt file 2018-11-06 22:23:37 -05:00
doc Give a better error if an attempt is made to set a zero length groups list 2018-11-08 11:27:03 +00:00
engines Change the build of engines to use ordinal files for symbol export 2018-10-05 08:22:42 +02:00
external/perl Update copyright year 2018-09-11 13:45:17 +01:00
fuzz GMAC implementation 2018-11-05 08:09:41 +10:00
include EVP_MAC ctrl numbering duplicate removal. 2018-11-06 07:04:36 +10:00
krb5@b9ad6c4950
ms Update copyright year 2018-05-01 13:34:30 +01:00
os-dep
pyca-cryptography@09403100de Update the pyca-cryptography submodule 2018-09-10 12:04:03 +01:00
ssl Give a better error if an attempt is made to set a zero length groups list 2018-11-08 11:27:03 +00:00
test Test: enable internal tests for shared Windows builds 2018-11-08 16:27:24 +01:00
tools Update copyright year 2018-03-20 13:08:46 +00:00
util util/add-depends.pl: go through shared_sources too 2018-11-07 14:38:20 +01:00
VMS
.gitattributes
.gitignore Ignore libcrypto.ld and libssl.ld 2018-10-03 16:40:18 +01:00
.gitmodules
.travis-apt-pin.preferences
.travis-create-release.sh Reduce travis-ci log output 2018-03-08 21:18:35 +01:00
.travis.yml Revert ".travis.yml: omit linux-ppc64le target." 2018-08-31 10:56:35 +02:00
ACKNOWLEDGEMENTS
appveyor.yml CI config: no need to make both install and install_docs 2018-05-14 17:51:48 +02:00
AUTHORS Update AUTHORS list, add commentary 2018-07-08 20:32:04 -04:00
build.info Simplify the processing of skipped source directories 2018-11-05 09:28:37 +01:00
CHANGES Build: make it possibly to specify subdirs in build.info 2018-11-05 09:27:31 +01:00
config Configure: move --noexecstack probe to Configure. 2018-05-05 20:44:56 +02:00
config.com Update copyright year 2018-02-13 13:59:25 +00:00
Configure Simplify the processing of skipped source directories 2018-11-05 09:28:37 +01:00
CONTRIBUTING Add a note on CHANGES and NEWS in CONTRIBUTING 2018-05-17 13:51:11 +02:00
e_os.h test/secmemtest: test secure memory only if it is implemented 2018-10-05 12:19:48 +02:00
FAQ
INSTALL typo-fixes: miscellaneous typo fixes 2018-09-21 23:55:22 +02:00
LICENSE Update the license end year 2018-01-20 10:02:23 +01:00
NEWS Add blurbs about EVP_MAC in NEWS and CHANGES 2018-10-30 08:57:34 +01:00
NOTES.ANDROID Configurations/15-android.conf: add support for "standalone toolchain". 2018-10-19 10:35:36 +02:00
NOTES.DJGPP
NOTES.PERL
NOTES.UNIX NOTES.UNIX: add "Linking your application" paragraph 2018-06-26 12:28:06 +02:00
NOTES.VMS
NOTES.WIN INSTALL,NOTES.WIN: classify no-asm as non-production option. 2018-07-25 15:47:12 +02:00
README The next version in master is at least 1.1.2, not 1.1.1x 2018-09-11 16:51:38 +02:00
README.ENGINE
README.FIPS

 OpenSSL 1.1.2-dev

 Copyright (c) 1998-2018 The OpenSSL Project
 Copyright (c) 1995-1998 Eric A. Young, Tim J. Hudson
 All rights reserved.

 DESCRIPTION
 -----------

 The OpenSSL Project is a collaborative effort to develop a robust,
 commercial-grade, fully featured, and Open Source toolkit implementing the
 Transport Layer Security (TLS) protocols (including SSLv3) as well as a
 full-strength general purpose cryptographic library.

 OpenSSL is descended from the SSLeay library developed by Eric A. Young
 and Tim J. Hudson.  The OpenSSL toolkit is licensed under a dual-license (the
 OpenSSL license plus the SSLeay license), which means that you are free to
 get and use it for commercial and non-commercial purposes as long as you
 fulfill the conditions of both licenses.

 OVERVIEW
 --------

 The OpenSSL toolkit includes:

 libssl (with platform specific naming):
     Provides the client and server-side implementations for SSLv3 and TLS.

 libcrypto (with platform specific naming):
     Provides general cryptographic and X.509 support needed by SSL/TLS but
     not logically part of it.

 openssl:
     A command line tool that can be used for:
        Creation of key parameters
        Creation of X.509 certificates, CSRs and CRLs
        Calculation of message digests
        Encryption and decryption
        SSL/TLS client and server tests
        Handling of S/MIME signed or encrypted mail
        And more...

 INSTALLATION
 ------------

 See the appropriate file:
        INSTALL         Linux, Unix, Windows, OpenVMS, ...
        NOTES.*         INSTALL addendums for different platforms

 SUPPORT
 -------

 See the OpenSSL website www.openssl.org for details on how to obtain
 commercial technical support. Free community support is available through the
 openssl-users email list (see
 https://www.openssl.org/community/mailinglists.html for further details).

 If you have any problems with OpenSSL then please take the following steps
 first:

    - Download the latest version from the repository
      to see if the problem has already been addressed
    - Configure with no-asm
    - Remove compiler optimization flags

 If you wish to report a bug then please include the following information
 and create an issue on GitHub:

    - OpenSSL version: output of 'openssl version -a'
    - Configuration data: output of 'perl configdata.pm --dump'
    - OS Name, Version, Hardware platform
    - Compiler Details (name, version)
    - Application Details (name, version)
    - Problem Description (steps that will reproduce the problem, if known)
    - Stack Traceback (if the application dumps core)

 Just because something doesn't work the way you expect does not mean it
 is necessarily a bug in OpenSSL. Use the openssl-users email list for this type
 of query.

 HOW TO CONTRIBUTE TO OpenSSL
 ----------------------------

 See CONTRIBUTING

 LEGALITIES
 ----------

 A number of nations restrict the use or export of cryptography. If you
 are potentially subject to such restrictions you should seek competent
 professional legal advice before attempting to develop or distribute
 cryptographic code.