openssl/test
David Benjamin 7966101e20 Allow DH_set0_key with only private key.
The pub_key field for DH isn't actually used in DH_compute_key at all.
(Note the peer public key is passed in as as BIGNUM.) It's mostly there
so the caller may extract it from DH_generate_key. It doesn't
particularly need to be present if filling in a DH from external
parameters.

The check in DH_set0_key conflicts with adding OpenSSL 1.1.0 to Node.
Their public API is a thin wrapper over the old OpenSSL one:
https://nodejs.org/api/crypto.html#crypto_class_diffiehellman

They have separate setPrivateKey and setPublicKey methods, so the public
key may be set last or not at all. In 1.0.2, either worked fine since
operations on DH objects generally didn't use the public key.  (Like
with OpenSSL, Node's setPublicKey method is also largely a no-op, but so
it goes.) In 1.1.0, DH_set0_key prevents create a private-key-only DH
object.

Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/4384)
2017-09-26 14:48:51 +02:00
..
certs Guard against DoS in name constraints handling. 2017-09-22 22:00:55 +02:00
ct
d2i-tests
ocsp-tests Fix OCSP_basic_verify() cert chain construction in case bs->certs is NULL 2017-08-16 14:32:38 -04:00
ossl_shim Fix an include location problem in the extrended tests. 2017-09-04 06:38:16 +10:00
recipes Guard against DoS in name constraints handling. 2017-09-22 22:00:55 +02:00
smime-certs Add alternative CMS P-256 cert 2017-08-10 16:48:18 +01:00
ssl-tests Add RSA-PSS certificate type TLS tests 2017-09-20 12:50:23 +01:00
testutil Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
aborttest.c
afalgtest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
asn1_encode_test.c Fix some typo and comments 2017-08-12 20:07:17 +02:00
asn1_internal_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
asn1_string_table_test.c [Win] Fix some test method signatures ... 2017-08-16 10:36:34 -04:00
asn1_time_test.c Fix return value of ASN1_TIME_compare 2017-08-30 11:24:02 -04:00
asynciotest.c Fix some typo and comments 2017-08-12 20:07:17 +02:00
asynctest.c asynctest: don't depend on apps 2017-03-28 14:40:25 +02:00
bad_dtls_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
bftest.c e_os.h removal from other headers and source files. 2017-08-30 07:20:43 +10:00
bio_enc_test.c Fix no-chacha and no-poly1305 2017-08-25 11:34:08 +01:00
bioprinttest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
bntest.c Move e_os.h to be the very first include. 2017-08-30 07:20:44 +10:00
bntests.pl
build.info Support key check in EVP interface 2017-09-13 20:38:14 +02:00
CAss.cnf
CAssdh.cnf
CAssdsa.cnf
CAssrsa.cnf
casttest.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
CAtsa.cnf Added support for ESSCertIDv2 2017-05-03 09:04:23 +02:00
chacha_internal_test.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
cipher_overhead_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
cipherbytes_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
cipherlist_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
ciphername_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
clienthellotest.c Fix test_client_hello with no-tls1_2_method 2017-09-07 13:21:56 -05:00
cms-examples.pl
constant_time_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
crltest.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
ct_test.c Change SETUP_TEST_FIXTURE so that the fixture structure is passed by 2017-08-07 08:57:05 +10:00
ctype_internal_test.c e_os.h removal from other headers and source files. 2017-08-30 07:20:43 +10:00
d2i_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
danetest.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
danetest.in
danetest.pem
destest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
dhtest.c Allow DH_set0_key with only private key. 2017-09-26 14:48:51 +02:00
drbgtest.c DRBG: clarify difference between entropy counts and buffer lengths 2017-08-28 08:52:02 -04:00
drbgtest.h Add DRBG random method 2017-07-19 03:25:16 -04:00
dsatest.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
dtls_mtu_test.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
dtlstest.c add callback handler for setting DTLS timer interval 2017-09-06 08:30:00 +02:00
dtlsv1listentest.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
ecdsatest.c [Win] Fix some test method signatures ... 2017-08-16 10:36:34 -04:00
ecstresstest.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
ectest.c MSC_VER <= 1200 isn't supported; remove dead code 2017-08-27 11:35:39 -04:00
enginetest.c OPENSSL_NO_ENGINE defined causes build failures 2017-07-28 09:25:59 +10:00
evp_extra_test.c Support EVP_PKEY_meth_remove and pmeth internal cleanup 2017-09-14 12:41:34 +08:00
evp_test.c Fix no-scrypt 2017-08-25 14:54:28 +01:00
evp_test.h Add support for multiple update calls in evp_test 2017-05-19 21:02:24 +01:00
exdatatest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
exptest.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
generate_buildtest.pl
generate_ssl_tests.pl Consolidate the locations where we have our internal perl modules 2017-08-15 11:30:47 +02:00
gmdifftest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
handshake_helper.c Introduce named constants for the ClientHello callback. 2017-09-08 13:58:59 -05:00
handshake_helper.h Add ExpectedServerCANames 2017-04-03 23:47:22 +01:00
hmactest.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
ideatest.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
igetest.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
lhash_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
md2test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
mdc2_internal_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
mdc2test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
memleaktest.c Update secmemtest and memeleaktest to use the test infrastructure. 2017-04-12 10:59:53 +01:00
modes_internal_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
P1ss.cnf
P2ss.cnf
packettest.c [Win] Fix some test method signatures ... 2017-08-16 10:36:34 -04:00
pbelutest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
pemtest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
pkcs7-1.pem
pkcs7.pem
pkey_meth_kdf_test.c Add PKEY_CTX setter tests for TLS1-PRF 2017-08-21 10:05:14 +01:00
pkey_meth_test.c [Win] Fix some test method signatures ... 2017-08-16 10:36:34 -04:00
pkits-test.pl
poly1305_internal_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
rc2test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
rc4test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
rc5test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
README Fix test documentation. 2017-09-08 13:58:59 -05:00
README.external Fix some Typos and indents 2017-08-11 10:16:33 -04:00
README.ssltest.md Fix test documentation. 2017-09-08 13:58:59 -05:00
recordlentest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
rsa_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
run_tests.pl test/run_tests.pl: don't use Module::Load::Conditional. 2017-09-02 20:20:51 +02:00
sanitytest.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
secmemtest.c Fix some Typos and indents 2017-08-11 10:16:33 -04:00
serverinfo2.pem Add a SERVERINFOV2 format test file 2017-05-03 14:37:42 +01:00
serverinfo.pem
servername_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
session.pem Update the test/session.pem to have a tick_nonce value 2017-07-07 15:02:09 +01:00
shibboleth.pfx
shlibloadtest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
siphash_internal_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
smcont.txt
srptest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
ssl_cert_table_internal_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
ssl_test_ctx_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
ssl_test_ctx_test.conf
ssl_test_ctx.c Rename SSL_CTX_set_early_cb to SSL_CTX_set_client_hello_cb. 2017-09-08 13:58:59 -05:00
ssl_test_ctx.h Rename SSL_CTX_set_early_cb to SSL_CTX_set_client_hello_cb. 2017-09-08 13:58:59 -05:00
ssl_test.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
ssl_test.tmpl
sslapitest.c Introduce named constants for the ClientHello callback. 2017-09-08 13:58:59 -05:00
sslbuffertest.c Fix some typo and comments 2017-08-12 20:07:17 +02:00
sslcorrupttest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
ssltest_old.c Move e_os.h to be the very first include. 2017-08-30 07:20:44 +10:00
ssltestlib.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
ssltestlib.h Add some tests for the new TLSv1.3 PSK code 2017-06-21 14:45:36 +01:00
Sssdsa.cnf
Sssrsa.cnf
stack_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
test_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
test.cnf
testcrl.pem
testdsa.pem
testdsapub.pem
testec-p256.pem
testecpub-p256.pem
testp7.pem
testreq2.pem
testrsa.pem
testrsapub.pem
testsid.pem
testutil.h Fix some typo and comments 2017-08-12 20:07:17 +02:00
testx509.pem
threadstest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
time_offset_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
tls13encryptiontest.c e_os.h removal from other headers and source files. 2017-08-30 07:20:43 +10:00
tls13secretstest.c Fix some Typos and indents 2017-08-11 10:16:33 -04:00
uitest.c [Win] Fix some test method signatures ... 2017-08-16 10:36:34 -04:00
Uss.cnf
v3-cert1.pem
v3-cert2.pem
v3ext.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
v3nametest.c Move e_os.h to be the very first include. 2017-08-30 07:20:44 +10:00
verify_extra_test.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
wpackettest.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
x509_check_cert_pkey_test.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
x509_dup_cert_test.c Update the test framework so that the need for test_main is removed. Everything 2017-07-27 07:53:08 +10:00
x509_internal_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
x509_time_test.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00
x509aux.c Use "" not <> for internal/ includes 2017-08-22 09:54:20 -04:00

How to add recipes
==================

For any test that you want to perform, you write a script located in
test/recipes/, named {nn}-test_{name}.t, where {nn} is a two digit number and
{name} is a unique name of your choice.

Please note that if a test involves a new testing executable, you will need to
do some additions in test/Makefile.  More on this later.


Naming conventions
=================

A test executable is named test/{name}test.c

A test recipe is named test/recipes/{nn}-test_{name}.t, where {nn} is a two
digit number and {name} is a unique name of your choice.

The number {nn} is (somewhat loosely) grouped as follows:

00-04  sanity, internal and essential API tests
05-09  individual symmetric cipher algorithms
10-14  math (bignum)
15-19  individual asymmetric cipher algorithms
20-24  openssl commands (some otherwise not tested)
25-29  certificate forms, generation and verification
30-35  engine and evp
60-79  APIs
   70  PACKET layer
80-89  "larger" protocols (CA, CMS, OCSP, SSL, TSA)
90-98  misc
99     most time consuming tests [such as test_fuzz]


A recipe that just runs a test executable
=========================================

A script that just runs a program looks like this:

    #! /usr/bin/perl

    use OpenSSL::Test::Simple;

    simple_test("test_{name}", "{name}test", "{name}");

{name} is the unique name you have chosen for your test.

The second argument to `simple_test' is the test executable, and `simple_test'
expects it to be located in test/

For documentation on OpenSSL::Test::Simple, do
`perldoc util/perl/OpenSSL/Test/Simple.pm'.


A recipe that runs a more complex test
======================================

For more complex tests, you will need to read up on Test::More and
OpenSSL::Test.  Test::More is normally preinstalled, do `man Test::More' for
documentation.  For OpenSSL::Test, do `perldoc util/perl/OpenSSL/Test.pm'.

A script to start from could be this:

    #! /usr/bin/perl

    use strict;
    use warnings;
    use OpenSSL::Test;

    setup("test_{name}");

    plan tests => 2;                # The number of tests being performed

    ok(test1, "test1");
    ok(test2, "test1");

    sub test1
    {
        # test feature 1
    }

    sub test2
    {
        # test feature 2
    }


Changes to test/build.info
==========================

Whenever a new test involves a new test executable you need to do the
following (at all times, replace {NAME} and {name} with the name of your
test):

* add {name} to the list of programs under PROGRAMS_NO_INST

* create a three line description of how to build the test, you will have
to modify the include paths and source files if you don't want to use the
basic test framework:

    SOURCE[{name}]={name}.c
    INCLUDE[{name}]=.. ../include
    DEPEND[{name}]=../libcrypto libtestutil.a

Generic form of C test executables
==================================

    #include "testutil.h"

    static int my_test(void)
    {
        int testresult = 0;                 /* Assume the test will fail    */
        int observed;

        observed = function();              /* Call the code under test     */
        if (!TEST_int_equal(observed, 2))   /* Check the result is correct  */
            goto end;                       /* Exit on failure - optional   */

        testresult = 1;                     /* Mark the test case a success */
    end:
        cleanup();                          /* Any cleanup you require      */
        return testresult;
    }

    int setup_tests(void)
    {
        ADD_TEST(my_test);                  /* Add each test separately     */
        return 1;                           /* Indicate success             */
    }

You should use the TEST_xxx macros provided by testutil.h to test all failure
conditions.  These macros produce an error message in a standard format if the
condition is not met (and nothing if the condition is met).  Additional
information can be presented with the TEST_info macro that takes a printf
format string and arguments.  TEST_error is useful for complicated conditions,
it also takes a printf format string and argument.  In all cases the TEST_xxx
macros are guaranteed to evaluate their arguments exactly once.  This means
that expressions with side effects are allowed as parameters.  Thus,

    if (!TEST_ptr(ptr = OPENSSL_malloc(..)))

works fine and can be used in place of:

    ptr = OPENSSL_malloc(..);
    if (!TEST_ptr(ptr))

The former produces a more meaningful message on failure than the latter.