Go to file
Matt Caswell 78021171db Fix -verify_return_error in s_client
The "verify_return_error" option in s_client is documented as:

 Return verification errors instead of continuing. This will typically
 abort the handshake with a fatal error.

In practice this option was ignored unless also accompanied with the
"-verify" option. It's unclear what the original intention was. One fix
could have been to change the documentation to match the actual behaviour.
However it seems unecessarily complex and unexpected that you should need
to have both options. Instead the fix implemented here is make the option
match the documentation so that "-verify" is not also required.

Note that s_server has a similar option where "-verify" (or "-Verify") is
still required. This makes more sense because those options additionally
request a certificate from the client. Without a certificate there is no
possibility of a verification failing, and so "-verify_return_error" doing
nothing seems ok.

Fixes #8079

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/8080)
2019-02-14 17:07:57 +00:00
.github
apps Fix -verify_return_error in s_client 2019-02-14 17:07:57 +00:00
boringssl@2070f8ad91
Configurations Windows/Cygwin dlls need the executable bit set 2019-02-13 20:00:28 +01:00
crypto Sparse array iterators include index position. 2019-02-14 09:09:51 +10:00
demos Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
doc Don't signal SSL_CB_HANDSHAKE_START for TLSv1.3 post-handshake messages 2019-02-14 16:17:34 +00:00
engines Fix master build. 2019-02-13 11:03:52 +10:00
external/perl Following the license change, modify the boilerplates in external/ 2018-12-06 15:39:02 +01:00
fuzz Build: Change all _NO_INST to use attributes instead. 2019-01-22 12:35:39 +01:00
include Added new EVP/KDF API. 2019-02-13 12:11:49 +01:00
krb5@b9ad6c4950
ms Following the license change, modify the boilerplates in ms/ 2018-12-06 14:22:20 +01:00
os-dep
pyca-cryptography@09403100de
ssl Don't signal SSL_CB_HANDSHAKE_START for TLSv1.3 post-handshake messages 2019-02-14 16:17:34 +00:00
test Don't signal SSL_CB_HANDSHAKE_START for TLSv1.3 post-handshake messages 2019-02-14 16:17:34 +00:00
tools
util Added new EVP/KDF API. 2019-02-13 12:11:49 +01:00
VMS Following the license change, modify the boilerplates in last few 2018-12-06 15:40:33 +01:00
.gitattributes
.gitignore
.gitmodules
.travis-apt-pin.preferences
.travis-create-release.sh
.travis.yml
ACKNOWLEDGEMENTS
appveyor.yml
AUTHORS
build.info Rework building: Get rid of old %unified_info structures 2019-01-21 19:31:32 +01:00
CHANGES Don't signal SSL_CB_HANDSHAKE_START for TLSv1.3 post-handshake messages 2019-02-14 16:17:34 +00:00
config Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
config.com Following the license change, modify the boilerplates in last few 2018-12-06 15:40:33 +01:00
Configure Configure: stop forcing use of DEFINE macros in headers 2019-02-14 09:40:28 +01:00
CONTRIBUTING Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
e_os.h Make sure build_SYS_str_reasons() preserves errno 2018-12-10 10:17:43 +00:00
FAQ
INSTALL Better phrasing around 1.1.0 2019-01-31 16:48:00 +01:00
LICENSE
NEWS
NOTES.ANDROID Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
NOTES.DJGPP Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
NOTES.PERL
NOTES.UNIX
NOTES.VMS Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
NOTES.WIN
README
README.ENGINE
README.FIPS

 OpenSSL 3.0.0-dev

 Copyright (c) 1998-2018 The OpenSSL Project
 Copyright (c) 1995-1998 Eric A. Young, Tim J. Hudson
 All rights reserved.

 DESCRIPTION
 -----------

 The OpenSSL Project is a collaborative effort to develop a robust,
 commercial-grade, fully featured, and Open Source toolkit implementing the
 Transport Layer Security (TLS) protocols (including SSLv3) as well as a
 full-strength general purpose cryptographic library.

 OpenSSL is descended from the SSLeay library developed by Eric A. Young
 and Tim J. Hudson.

 The OpenSSL toolkit is licensed under the Apache License 2.0, which means
 that you are free to get and use it for commercial and non-commercial
 purposes as long as you fulfill its conditions.

 OVERVIEW
 --------

 The OpenSSL toolkit includes:

 libssl (with platform specific naming):
     Provides the client and server-side implementations for SSLv3 and TLS.

 libcrypto (with platform specific naming):
     Provides general cryptographic and X.509 support needed by SSL/TLS but
     not logically part of it.

 openssl:
     A command line tool that can be used for:
        Creation of key parameters
        Creation of X.509 certificates, CSRs and CRLs
        Calculation of message digests
        Encryption and decryption
        SSL/TLS client and server tests
        Handling of S/MIME signed or encrypted mail
        And more...

 INSTALLATION
 ------------

 See the appropriate file:
        INSTALL         Linux, Unix, Windows, OpenVMS, ...
        NOTES.*         INSTALL addendums for different platforms

 SUPPORT
 -------

 See the OpenSSL website www.openssl.org for details on how to obtain
 commercial technical support. Free community support is available through the
 openssl-users email list (see
 https://www.openssl.org/community/mailinglists.html for further details).

 If you have any problems with OpenSSL then please take the following steps
 first:

    - Download the latest version from the repository
      to see if the problem has already been addressed
    - Configure with no-asm
    - Remove compiler optimization flags

 If you wish to report a bug then please include the following information
 and create an issue on GitHub:

    - OpenSSL version: output of 'openssl version -a'
    - Configuration data: output of 'perl configdata.pm --dump'
    - OS Name, Version, Hardware platform
    - Compiler Details (name, version)
    - Application Details (name, version)
    - Problem Description (steps that will reproduce the problem, if known)
    - Stack Traceback (if the application dumps core)

 Just because something doesn't work the way you expect does not mean it
 is necessarily a bug in OpenSSL. Use the openssl-users email list for this type
 of query.

 HOW TO CONTRIBUTE TO OpenSSL
 ----------------------------

 See CONTRIBUTING

 LEGALITIES
 ----------

 A number of nations restrict the use or export of cryptography. If you
 are potentially subject to such restrictions you should seek competent
 professional legal advice before attempting to develop or distribute
 cryptographic code.