mirror of
https://github.com/openssl/openssl.git
synced 2024-11-27 05:21:51 +08:00
6c61b27496
When the proxy re-encrypted a TLSv1.3 record it was adding a spurious byte onto the end. This commit removes that. The "extra" byte was intended to be the inner content type of the record. However, TLSProxy was actually adding the original encrypted data into the record (which already has the inner content type in it) and then adding the spurious additional content type byte on the end (and adjusting the record length accordingly). It is interesting to look at why this didn't cause a failure: The receiving peer first attempts to decrypt the data. Because this is TLSProxy we always use a GCM based ciphersuite with a 16 byte tag. When we decrypt this it actually gets diverted to the ossltest engine. All this does is go through the motions of encrypting/decrypting but just passes back the original data. Crucially it will never fail because of a bad tag! The receiving party thinks the spurious additional byte is part of the tag and the ossltest engine ignores it. This means the data that gets passed back to the record layer still has an additional spurious byte on it - but because the 16 byte tag has been removed, this is actually the first byte of the original tag. Again because we are using ossltest engine we aren't actually creating "real" tags - we only ever emit 16, 0 bytes for the tag. So the spurious additional byte always has the value 0. The TLSv1.3 spec says that records can have additional 0 bytes on the end of them - this is "padding". So the record layer interprets this 0 byte as padding and strips it off to end up with the originally transmitted record data - which it can now process successfully. Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/5370) |
||
|---|---|---|
| .. | ||
| perl | ||
| build.info | ||
| ck_errf.pl | ||
| copy.pl | ||
| dofile.pl | ||
| find-doc-nits | ||
| find-unused-errs | ||
| indent.pro | ||
| libcrypto.num | ||
| libssl.num | ||
| local_shlib.com.in | ||
| mkbuildinf.pl | ||
| mkdef.pl | ||
| mkdir-p.pl | ||
| mkerr.pl | ||
| mkrc.pl | ||
| openssl-format-source | ||
| openssl-update-copyright | ||
| opensslwrap.sh | ||
| private.num | ||
| process_docs.pl | ||
| shlib_wrap.sh.in | ||
| su-filter.pl | ||
| unlocal_shlib.com.in | ||