openssl/crypto
Matt Caswell 1dc5128577 Fix no-dh
One of the x509 tests checks to make sure spurious errors don't appear on
the stack. The x509 app uses the OSSL_STORE code to load things. The
OSSL_STORE code will try various different formats - which results in
lots of failures. However those failures are typically suppressed by
OSSL_STORE unless they are interesting. OSSL_STORE thinks it knows what
kind of errors are uninteresting (ASN.1 errors) but gets confused if
upper levels of code add additional errors to the stack. This was
happening in the DSA code which confused OSSL_STORE and meant the errors
were not being suppressed properly - and hence the x509 test failed.

Interestingly this only impacts a no-dh build, because in a no-dh build
the DSA param decoder suddenly becomes the last to be tried. If it
happens earlier in the list the errors end up getting suppressed anyway.

The simplest solution is to just to remove the error from the DSA param
decoder code. It's not adding any useful information anyway.

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/13162)
2020-10-19 16:11:40 +01:00
..
aes Ignore vendor name in Clang version number. 2020-08-27 20:27:26 -07:00
aria
asn1 Update copyright year 2020-10-15 14:10:06 +01:00
async Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
bf Update copyright year 2020-04-23 13:55:52 +01:00
bio Update copyright year 2020-10-15 14:10:06 +01:00
bn Rename some occurrences of 'library_context' and 'lib_ctx' to 'libctx' 2020-10-15 12:00:21 +01:00
buffer
camellia Update copyright year 2020-04-23 13:55:52 +01:00
cast Fix logic error for building x86 CAST assembly 2020-06-14 12:35:34 -07:00
chacha Ignore vendor name in Clang version number. 2020-08-27 20:27:26 -07:00
cmac Delete unused PKEY MAC files 2020-08-29 17:40:11 +10:00
cmp Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
cms Update copyright year 2020-10-15 14:10:06 +01:00
comp
conf Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
crmf Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
ct Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
des Build: Remove faulty DES assembler spec 2020-06-20 11:02:18 +02:00
dh DH: have DH_set_length() increment the dirty count. 2020-10-19 12:14:11 +02:00
dsa Fix no-dh 2020-10-19 16:11:40 +01:00
dso Fix safestack issues in crypto.h 2020-09-13 11:11:21 +01:00
ec Update copyright year 2020-10-15 14:10:06 +01:00
encode_decode ENCODER & DECODER: set params on all encoder/decoder instances, unconditionally 2020-10-17 11:56:37 +02:00
engine Fix safestack issues in conf.h 2020-09-13 11:11:20 +01:00
err Move CMS enveloping code out of the algorithms and into CMS 2020-10-15 10:00:19 +01:00
ess Fix safestack issues in ess.h 2020-09-13 11:10:41 +01:00
evp Update copyright year 2020-10-15 14:10:06 +01:00
ffc Rename some occurrences of 'library_context' and 'lib_ctx' to 'libctx' 2020-10-15 12:00:21 +01:00
hmac Delete unused PKEY MAC files 2020-08-29 17:40:11 +10:00
http Fix Coverity CID 1466708 - correct pointer calculation in one case 2020-09-17 15:29:46 +02:00
idea Update copyright year 2020-04-23 13:55:52 +01:00
kdf
lhash
md2 Update copyright year 2020-04-23 13:55:52 +01:00
md4 Update copyright year 2020-04-23 13:55:52 +01:00
md5 In a non-shared build, don't include the md5 object files in legacy provider 2020-09-09 17:59:08 +10:00
mdc2 Update copyright year 2020-04-23 13:55:52 +01:00
modes Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
objects Some OIDs used in Russian X.509 certificates. 2020-10-05 12:14:17 +03:00
ocsp Update copyright year 2020-10-15 14:10:06 +01:00
pem Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
perlasm Fix many MarkDown issues in {NOTES*,README*,HACKING,LICENSE}.md files 2020-07-05 11:29:43 +02:00
pkcs7 Update copyright year 2020-10-15 14:10:06 +01:00
pkcs12 Update copyright year 2020-10-15 14:10:06 +01:00
poly1305 Diverse build.info: Adjust paths 2020-09-10 09:50:56 +02:00
property Update copyright year 2020-10-15 14:10:06 +01:00
rand Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
rc2 Update copyright year 2020-04-23 13:55:52 +01:00
rc4 Update copyright year 2020-04-23 13:55:52 +01:00
rc5 Update copyright year 2020-04-23 13:55:52 +01:00
ripemd Diverse build.info: Adjust paths 2020-09-10 09:50:56 +02:00
rsa Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
seed Update copyright year 2020-04-23 13:55:52 +01:00
sha Ignore vendor name in Clang version number. 2020-08-27 20:27:26 -07:00
siphash Delete unused PKEY MAC files 2020-08-29 17:40:11 +10:00
sm2 Update copyright year 2020-10-15 14:10:06 +01:00
sm3
sm4
srp Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
stack
store Update copyright year 2020-10-15 14:10:06 +01:00
ts Correct and simplify use of ERR_clear_error() etc. for loading DSO libs 2020-10-08 16:57:34 +02:00
txt_db
ui Fix safestack issues in ui.h 2020-09-13 11:11:21 +01:00
whrlpool Avoid undefined behavior with unaligned accesses 2020-05-27 20:11:20 +02:00
x509 Changing X509at_get0_data_by_OBJ to expect const stack of X509_ATTRIBUTE 2020-10-15 13:54:21 +01:00
alphacpuid.pl Update copyright year 2020-04-23 13:55:52 +01:00
arm64cpuid.pl Update copyright year 2020-04-23 13:55:52 +01:00
arm_arch.h
armcap.c
armv4cpuid.pl Update copyright year 2020-04-23 13:55:52 +01:00
asn1_dsa.c Update copyright year 2020-10-15 14:10:06 +01:00
bsearch.c
build.info Punycode decoding implementation 2020-08-26 14:04:11 +03:00
c64xpluscpuid.pl Update copyright year 2020-04-23 13:55:52 +01:00
context.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
core_algorithm.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
core_fetch.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
core_namemap.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
cpt_err.c Add a "random" configuration section. 2020-09-23 15:28:29 +10:00
cryptlib.c Update copyright year 2020-10-15 14:10:06 +01:00
ctype.c
cversion.c
der_writer.c der: _ossl prefix DER functions 2020-10-01 11:25:12 +10:00
dllmain.c
ebcdic.c
ex_data.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
getenv.c Update copyright year 2020-10-15 14:10:06 +01:00
ia64cpuid.S
info.c Print CPUINFO also for s390 processors 2020-06-22 02:35:01 +02:00
init.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
initthread.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
LPdir_nyi.c
LPdir_unix.c
LPdir_vms.c
LPdir_win32.c
LPdir_win.c
LPdir_wince.c
mem_clr.c
mem_sec.c Fix wrong return value check of mmap function 2020-06-23 10:08:28 +10:00
mem.c Rename FIPS_MODE to FIPS_MODULE 2020-04-28 15:37:37 +02:00
mips_arch.h
o_dir.c
o_fopen.c
o_init.c
o_str.c Enable WinCE build without deceiving _MSC_VER. 2020-07-15 23:03:22 +02:00
o_time.c Update copyright year 2020-07-16 14:47:04 +02:00
packet.c WPACKET: don't write DER length when we don't want to 2020-05-04 05:50:06 +02:00
param_build_set.c DH: make the private key length importable / exportable 2020-10-19 12:14:11 +02:00
param_build.c params: add OSSL_PARAM helpers for time_t. 2020-06-24 20:05:41 +10:00
params_from_text.c params: handle the modified sentinel. 2020-04-25 18:46:01 +10:00
params.c OSSL_PARAM: Add string pointer getters 2020-08-24 10:02:26 +02:00
pariscid.pl Update copyright year 2020-04-23 13:55:52 +01:00
passphrase.c CORE: Fix small bug in passphrase caching 2020-09-03 17:48:32 +02:00
ppc_arch.h
ppccap.c Update copyright year 2020-05-15 14:09:49 +01:00
ppccpuid.pl Update copyright year 2020-04-23 13:55:52 +01:00
provider_conf.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
provider_core.c Rename some occurrences of 'library_context' and 'lib_ctx' to 'libctx' 2020-10-15 12:00:21 +01:00
provider_local.h
provider_predefined.c serialisation: Add a built-in base provider. 2020-07-30 20:15:22 +10:00
provider.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
punycode.c Update copyright year 2020-10-15 14:10:06 +01:00
README-sparse_array.md Fix many MarkDown issues in {NOTES*,README*,HACKING,LICENSE}.md files 2020-07-05 11:29:43 +02:00
s390x_arch.h Update copyright year 2020-04-23 13:55:52 +01:00
s390xcap.c
s390xcpuid.pl Update copyright year 2020-04-23 13:55:52 +01:00
self_test_core.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
sparc_arch.h
sparccpuid.S
sparcv9cap.c Update copyright year 2020-04-23 13:55:52 +01:00
sparse_array.c Update copyright year 2020-10-15 14:10:06 +01:00
threads_none.c
threads_pthread.c todo: remove fork protection todo comment, it isn't relevant to the FIPS provider 2020-09-28 08:49:05 +10:00
threads_win.c Update copyright year 2020-04-23 13:55:52 +01:00
trace.c Run the withlibctx.pl script 2020-10-01 09:25:20 +01:00
uid.c
vms_rms.h
x86_64cpuid.pl Update copyright year 2020-04-23 13:55:52 +01:00
x86cpuid.pl Update copyright year 2020-04-23 13:55:52 +01:00