openssl/test
Shane Lontis 55f02cb684 Change DH_get_nid() to set the value of q if it is not already set
Fixes #11108.

It only sets q if a valid named group is found.
The function signature was recently changed to pass a non const DH pointer
in order to allow the nid to be cached internally. As an extension of this
the value of q can now also be set as q is always known for named groups.
The length field is also set if q is set.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/11114)
2020-03-07 07:47:58 +10:00
..
certs Generate new Ed488 certificates 2020-02-11 23:23:42 +01:00
ct Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
d2i-tests
ocsp-tests
ossl_shim
recipes Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
smime-certs
ssl-tests Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
testutil
aborttest.c
aesgcmtest.c
afalgtest.c
asn1_decode_test.c
asn1_dsa_internal_test.c
asn1_encode_test.c
asn1_internal_test.c
asn1_string_table_test.c
asn1_time_test.c
asynciotest.c
asynctest.c
bad_dtls_test.c
bftest.c
bio_callback_test.c
bio_enc_test.c
bio_memleak_test.c
bio_prefix_text.c
bioprinttest.c
bn_internal_test.c
bn_rand_range.h
bntest.c
bntests.pl
build.info Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
CAss.cnf Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
casttest.c
CAtsa.cnf
chacha_internal_test.c
cipher_overhead_test.c
cipherbytes_test.c
cipherlist_test.c
ciphername_test.c
clienthellotest.c
cmp_asn_test.c
cmp_ctx_test.c chunk 7 of CMP contribution to OpenSSL 2020-02-17 07:43:58 +01:00
cmp_hdr_test.c fix various formatting nits in CMP contribution chunks 1-6 found by the new util/check-format.pl 2020-02-17 07:43:58 +01:00
cmp_msg_test.c fix various formatting nits in CMP contribution chunks 1-6 found by the new util/check-format.pl 2020-02-17 07:43:58 +01:00
cmp_protect_test.c chunk 7 of CMP contribution to OpenSSL 2020-02-17 07:43:58 +01:00
cmp_status_test.c
cmp_testlib.c
cmp_testlib.h
cmp_vfy_test.c chunk 7 of CMP contribution to OpenSSL 2020-02-17 07:43:58 +01:00
cms-examples.pl
cmsapitest.c
conf_include_test.c
confdump.c
constant_time_test.c
context_internal_test.c
crltest.c
ct_test.c Create a new embeddedSCTs1 that's signed using SHA256 2020-02-05 22:04:37 +01:00
ctype_internal_test.c
curve448_internal_test.c Implement a stricter ECX_KEY type 2020-02-11 22:32:47 +00:00
d2i_test.c
danetest.c
danetest.in
danetest.pem
default-and-fips.cnf Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
default-and-legacy.cnf
default.cnf
destest.c
dhtest.c Change DH_get_nid() to set the value of q if it is not already set 2020-03-07 07:47:58 +10:00
drbg_cavs_data_ctr.c
drbg_cavs_data_hash.c
drbg_cavs_data_hmac.c
drbg_cavs_data.h
drbg_cavs_test.c
drbgtest.c tests/drbgtest: use new RAND_DRBG callback_data API instead of ex_data 2020-02-07 11:38:57 +01:00
drbgtest.h
dsa_no_digest_size_test.c Deprecate the low level DSA functions. 2020-02-12 08:52:41 +10:00
dsatest.c Deprecate the low level DSA functions. 2020-02-12 08:52:41 +10:00
dtls_mtu_test.c
dtlstest.c
dtlsv1listentest.c
ec_internal_test.c Deprecate the ECDSA and EV_KEY_METHOD functions. 2020-02-04 20:02:55 +10:00
ecdsatest.c Fix no-sm2 2020-02-06 13:57:35 +00:00
ecdsatest.h
ecstresstest.c
ectest.c
enginetest.c
errtest.c
evp_extra_test.c test/evp_extra_test.c: adapt for RSA signature tests 2020-02-22 01:07:15 +01:00
evp_fetch_prov_test.c Introduce the provider property 2020-02-21 20:17:02 +00:00
evp_kdf_test.c
evp_pkey_dparams_test.c
evp_pkey_provided_test.c Add DH key validation to default provider 2020-03-05 08:25:55 +10:00
evp_test.c Params: add argument to the _from_text calls to indicate if the param exists. 2020-02-21 13:04:25 +01:00
evp_test.h
exdatatest.c
exptest.c
fatalerrtest.c
ffc_internal_test.c Coverity 1458438: fix uninitialised memory access. 2020-02-17 19:29:05 +10:00
fips.cnf Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
generate_buildtest.pl
generate_ssl_tests.pl TEST: Optionally silence OpenSSL::Test::setup() 2020-02-18 09:45:53 +01:00
gmdifftest.c
gosttest.c
handshake_helper.c
handshake_helper.h
hmactest.c
http_test.c Generalize the HTTP client so far implemented mostly in crypto/ocsp/ocsp_ht.c 2020-02-10 16:49:37 +01:00
ideatest.c
igetest.c
keymgmt_internal_test.c EVP: Add evp_pkey_upgrade_to_provider(), for EVP_PKEY upgrades 2020-02-29 05:39:43 +01:00
legacy.cnf
lhash_test.c
mdc2_internal_test.c
mdc2test.c
memleaktest.c
modes_internal_test.c
namemap_internal_test.c
ocspapitest.c
ossl_test_endian.h
P1ss.cnf Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
P2ss.cnf Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
p_test.c
packettest.c
param_build_test.c Remove unused ossl_param_bld_to_param_ex() function. 2020-02-12 19:45:42 +10:00
params_api_test.c
params_conversion_test.c
params_test.c
pbelutest.c
pemtest.c
pkcs7-1.pem
pkcs7.pem
pkey_meth_kdf_test.c
pkey_meth_test.c
pkits-test.pl
poly1305_internal_test.c
property_test.c
provider_internal_test.c
provider_internal_test.cnf.in Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
provider_test.c
rc2test.c
rc4test.c
rc5test.c
rdrand_sanitytest.c
README
README.external
README.ssltest.md Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
recordlentest.c
rsa_complex.c
rsa_mp_test.c Deprecate the low level RSA functions. 2020-02-20 18:58:40 +10:00
rsa_sp800_56b_test.c
rsa_test.c Deprecate the low level RSA functions. 2020-02-20 18:58:40 +10:00
run_tests.pl
sanitytest.c
secmemtest.c Make secure-memory be a config option 2020-02-14 15:18:27 +01:00
serverinfo2.pem
serverinfo.pem
servername_test.c
session.pem
shibboleth.pfx
shlibloadtest.c
siphash_internal_test.c
sm2_internal_test.c Deprecate the ECDSA and EV_KEY_METHOD functions. 2020-02-04 20:02:55 +10:00
sm4_internal_test.c
smcont.txt
sparse_array_test.c
srptest.c
ssl_cert_table_internal_test.c
ssl_ctx_test.c
ssl_test_ctx_test.c Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
ssl_test_ctx_test.cnf Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
ssl_test_ctx.c
ssl_test_ctx.h
ssl_test.c
ssl_test.tmpl
sslapitest.c Fix no-tls1_3 2020-02-06 12:13:47 +00:00
sslbuffertest.c
sslcorrupttest.c
sslprovidertest.c Add a test for SSL_CTX_new_with_libctx() 2020-02-06 11:59:07 +00:00
ssltest_old.c Deprecate the low level Diffie-Hellman functions. 2020-02-20 19:04:57 +10:00
ssltestlib.c Don't exclude quite so much in a no-sock build 2020-02-21 21:41:56 +01:00
ssltestlib.h
stack_test.c
sysdefault.cnf
sysdefaulttest.c
test_test.c
test.cnf
testcrl.pem
testdsa.pem
testdsapub.pem
testec-p256.pem
testecpub-p256.pem
tested448.pem
tested448pub.pem
tested25519.pem
tested25519pub.pem
testp7.pem
testreq2.pem
testrsa.pem
testrsapub.pem
testsid.pem
testutil.h
testx509.pem
threadstest.c
time_offset_test.c
tls13ccstest.c
tls13encryptiontest.c
tls13secretstest.c Explicitly fetch ciphers and digests in libssl 2020-02-06 11:59:07 +00:00
uitest.c
Uss.cnf Use .cnf for config files, not .conf 2020-03-06 18:25:13 +01:00
v3-cert1.pem
v3-cert2.pem
v3ext.c
v3nametest.c
verify_extra_test.c
versions.c
wpackettest.c
x509_check_cert_pkey_test.c
x509_dup_cert_test.c
x509_internal_test.c
x509_time_test.c
x509aux.c

How to add recipes
==================

For any test that you want to perform, you write a script located in
test/recipes/, named {nn}-test_{name}.t, where {nn} is a two digit number and
{name} is a unique name of your choice.

Please note that if a test involves a new testing executable, you will need to
do some additions in test/build.info. Please refer to the section "Changes to 
test/build.info" below.


Naming conventions
=================

A test executable is named test/{name}test.c

A test recipe is named test/recipes/{nn}-test_{name}.t, where {nn} is a two
digit number and {name} is a unique name of your choice.

The number {nn} is (somewhat loosely) grouped as follows:

00-04  sanity, internal and essential API tests
05-09  individual symmetric cipher algorithms
10-14  math (bignum)
15-19  individual asymmetric cipher algorithms
20-24  openssl commands (some otherwise not tested)
25-29  certificate forms, generation and verification
30-35  engine and evp
60-79  APIs:
   60  X509 subsystem
   61  BIO subsystem
   65  CMP subsystem
   70  PACKET layer
80-89  "larger" protocols (CA, CMS, OCSP, SSL, TSA)
90-98  misc
99     most time consuming tests [such as test_fuzz]


A recipe that just runs a test executable
=========================================

A script that just runs a program looks like this:

    #! /usr/bin/perl

    use OpenSSL::Test::Simple;

    simple_test("test_{name}", "{name}test", "{name}");

{name} is the unique name you have chosen for your test.

The second argument to `simple_test' is the test executable, and `simple_test'
expects it to be located in test/

For documentation on OpenSSL::Test::Simple, do
`perldoc util/perl/OpenSSL/Test/Simple.pm'.


A recipe that runs a more complex test
======================================

For more complex tests, you will need to read up on Test::More and
OpenSSL::Test.  Test::More is normally preinstalled, do `man Test::More' for
documentation.  For OpenSSL::Test, do `perldoc util/perl/OpenSSL/Test.pm'.

A script to start from could be this:

    #! /usr/bin/perl

    use strict;
    use warnings;
    use OpenSSL::Test;

    setup("test_{name}");

    plan tests => 2;                # The number of tests being performed

    ok(test1, "test1");
    ok(test2, "test1");

    sub test1
    {
        # test feature 1
    }

    sub test2
    {
        # test feature 2
    }


Changes to test/build.info
==========================

Whenever a new test involves a new test executable you need to do the
following (at all times, replace {NAME} and {name} with the name of your
test):

* add {name} to the list of programs under PROGRAMS_NO_INST

* create a three line description of how to build the test, you will have
to modify the include paths and source files if you don't want to use the
basic test framework:

    SOURCE[{name}]={name}.c
    INCLUDE[{name}]=.. ../include ../apps/include
    DEPEND[{name}]=../libcrypto libtestutil.a

Generic form of C test executables
==================================

    #include "testutil.h"

    static int my_test(void)
    {
        int testresult = 0;                 /* Assume the test will fail    */
        int observed;

        observed = function();              /* Call the code under test     */
        if (!TEST_int_eq(observed, 2))      /* Check the result is correct  */
            goto end;                       /* Exit on failure - optional   */

        testresult = 1;                     /* Mark the test case a success */
    end:
        cleanup();                          /* Any cleanup you require      */
        return testresult;
    }

    int setup_tests(void)
    {
        ADD_TEST(my_test);                  /* Add each test separately     */
        return 1;                           /* Indicate success             */
    }

You should use the TEST_xxx macros provided by testutil.h to test all failure
conditions.  These macros produce an error message in a standard format if the
condition is not met (and nothing if the condition is met).  Additional
information can be presented with the TEST_info macro that takes a printf
format string and arguments.  TEST_error is useful for complicated conditions,
it also takes a printf format string and argument.  In all cases the TEST_xxx
macros are guaranteed to evaluate their arguments exactly once.  This means
that expressions with side effects are allowed as parameters.  Thus,

    if (!TEST_ptr(ptr = OPENSSL_malloc(..)))

works fine and can be used in place of:

    ptr = OPENSSL_malloc(..);
    if (!TEST_ptr(ptr))

The former produces a more meaningful message on failure than the latter.