openssl/crypto/ec
Nicola Tuveri 00da0f6989 [crypto/ec] Remove unreachable AVX2 code in NISTZ256 implementation
`crypto/ec/ecp_nistz256.c` contained code sections guarded by a
`ECP_NISTZ256_AVX2` define.

The relevant comment read:

> /*
>  * Note that by default ECP_NISTZ256_AVX2 is undefined. While it's great
>  * code processing 4 points in parallel, corresponding serial operation
>  * is several times slower, because it uses 29x29=58-bit multiplication
>  * as opposite to 64x64=128-bit in integer-only scalar case. As result
>  * it doesn't provide *significant* performance improvement. Note that
>  * just defining ECP_NISTZ256_AVX2 is not sufficient to make it work,
>  * you'd need to compile even asm/ecp_nistz256-avx.pl module.
>  */

Without diminishing the quality of the original submission, it's evident
that this code has been basically unreachable without modifications to
the library source code and is under-tested.

This commit removes these sections from the codebase.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/12019)
2020-06-04 18:35:28 +03:00
..
asm [crypto/ec] Remove unreachable AVX2 code in NISTZ256 implementation 2020-06-04 18:35:28 +03:00
curve448 Update copyright year 2020-04-23 13:55:52 +01:00
build.info s390: ECX key generation fixes. 2020-04-17 19:51:37 +10:00
curve25519.c Update copyright year 2020-04-23 13:55:52 +01:00
ec2_oct.c Rename FIPS_MODE to FIPS_MODULE 2020-04-28 15:37:37 +02:00
ec2_smpl.c deprecate EC_POINT_make_affine and EC_POINTs_make_affine 2020-05-20 20:10:31 +02:00
ec_ameth.c Constify X509_PUBKEY_get(), X509_PUBKEY_get0(), and X509_PUBKEY_get0_param() 2020-05-26 09:35:05 +02:00
ec_asn1.c Move EC_METHOD to internal-only 2020-06-02 11:17:24 +03:00
ec_backend.c Update core_names.h fields and document most fields. 2020-05-26 13:53:07 +10:00
ec_check.c Rename FIPS_MODE to FIPS_MODULE 2020-04-28 15:37:37 +02:00
ec_ctrl.c Rename FIPS_MODE to FIPS_MODULE 2020-04-28 15:37:37 +02:00
ec_curve.c Move EC_METHOD to internal-only 2020-06-02 11:17:24 +03:00
ec_cvt.c Move EC_METHOD to internal-only 2020-06-02 11:17:24 +03:00
ec_err.c ecx: check for errors creating public keys from private ones. 2020-04-17 19:51:37 +10:00
ec_key.c Move EC_METHOD to internal-only 2020-06-02 11:17:24 +03:00
ec_kmeth.c Rename FIPS_MODE to FIPS_MODULE 2020-04-28 15:37:37 +02:00
ec_lib.c Move EC_METHOD to internal-only 2020-06-02 11:17:24 +03:00
ec_local.h Move EC_METHOD to internal-only 2020-06-02 11:17:24 +03:00
ec_mult.c deprecate EC_POINT_make_affine and EC_POINTs_make_affine 2020-05-20 20:10:31 +02:00
ec_oct.c Update copyright year 2020-04-23 13:55:52 +01:00
ec_pmeth.c Update copyright year 2020-04-23 13:55:52 +01:00
ec_print.c Update copyright year 2020-04-23 13:55:52 +01:00
ecdh_kdf.c Update copyright year 2020-04-23 13:55:52 +01:00
ecdh_ossl.c Update copyright year 2020-04-23 13:55:52 +01:00
ecdsa_ossl.c Update copyright year 2020-04-23 13:55:52 +01:00
ecdsa_sign.c Update copyright year 2020-04-23 13:55:52 +01:00
ecdsa_vrf.c Update copyright year 2020-04-23 13:55:52 +01:00
eck_prn.c Update copyright year 2020-06-04 14:33:57 +01:00
ecp_mont.c Update copyright year 2020-04-23 13:55:52 +01:00
ecp_nist.c Update copyright year 2020-04-23 13:55:52 +01:00
ecp_nistp224.c Avoid undefined behavior with unaligned accesses 2020-05-27 20:11:20 +02:00
ecp_nistp256.c Rename FIPS_MODE to FIPS_MODULE 2020-04-28 15:37:37 +02:00
ecp_nistp521.c Avoid undefined behavior with unaligned accesses 2020-05-27 20:11:20 +02:00
ecp_nistputil.c Update copyright year 2020-04-23 13:55:52 +01:00
ecp_nistz256_table.c
ecp_nistz256.c [crypto/ec] Remove unreachable AVX2 code in NISTZ256 implementation 2020-06-04 18:35:28 +03:00
ecp_oct.c Rename FIPS_MODE to FIPS_MODULE 2020-04-28 15:37:37 +02:00
ecp_s390x_nistp.c Move EC_METHOD to internal-only 2020-06-02 11:17:24 +03:00
ecp_smpl.c Update copyright year 2020-04-23 13:55:52 +01:00
ecx_backend.c Add the ability to ECX to import keys with only the private key 2020-05-04 09:30:55 +01:00
ecx_backend.h Fix the KEYNID2TYPE macro 2020-05-04 09:30:55 +01:00
ecx_key.c Add the library ctx into an ECX_KEY 2020-05-04 09:30:55 +01:00
ecx_meth.c Constify X509_PUBKEY_get(), X509_PUBKEY_get0(), and X509_PUBKEY_get0_param() 2020-05-26 09:35:05 +02:00
ecx_s390x.c Update copyright year 2020-04-23 13:55:52 +01:00