mirror of
https://github.com/openssl/openssl.git
synced 2025-02-23 14:42:15 +08:00
1dc5128577
One of the x509 tests checks to make sure spurious errors don't appear on the stack. The x509 app uses the OSSL_STORE code to load things. The OSSL_STORE code will try various different formats - which results in lots of failures. However those failures are typically suppressed by OSSL_STORE unless they are interesting. OSSL_STORE thinks it knows what kind of errors are uninteresting (ASN.1 errors) but gets confused if upper levels of code add additional errors to the stack. This was happening in the DSA code which confused OSSL_STORE and meant the errors were not being suppressed properly - and hence the x509 test failed. Interestingly this only impacts a no-dh build, because in a no-dh build the DSA param decoder suddenly becomes the last to be tried. If it happens earlier in the list the errors end up getting suppressed anyway. The simplest solution is to just to remove the error from the DSA param decoder code. It's not adding any useful information anyway. Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/13162) |
||
|---|---|---|
| .. | ||
| build.info | ||
| dsa_ameth.c | ||
| dsa_asn1.c | ||
| dsa_backend.c | ||
| dsa_check.c | ||
| dsa_depr.c | ||
| dsa_err.c | ||
| dsa_gen.c | ||
| dsa_key.c | ||
| dsa_lib.c | ||
| dsa_local.h | ||
| dsa_meth.c | ||
| dsa_ossl.c | ||
| dsa_pmeth.c | ||
| dsa_prn.c | ||
| dsa_sign.c | ||
| dsa_vrf.c | ||